Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window trust with empty workspaces #124824

Closed
aeschli opened this issue May 28, 2021 · 4 comments
Closed

Window trust with empty workspaces #124824

aeschli opened this issue May 28, 2021 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workspace-trust Trusted workspaces
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented May 28, 2021

  • open an new empty window
  • hover over the restriction info in the status bar says:

Restricted mode: Some features are disabled because this window is not trusted.

  • click on it

  • the tab title says 'Workspace Trust` (IMO this should become Restricted Mode, also with workspaces)
    image

  • The section mentions 'In trusted window'. Good, (but should be capitalized: Trusted Window )

  • It also mentions16 workspace settings are not applied. That's strange, how can there be workspace settings. Click on the link, there are no workspace settings . Also when I go to the settings page there are no workspace settings

  • trust the window, reload the window, the window is restricted again

  • open a new window (restricted) , use Add folder to workspace, choose a folder that is trusted : the window is now suddenly unrestricted

If the restrictedness is a property of the window, then the window should keep its restricted state across reloads and operations.
If the restrictedness is a property of the workspace, then it's strange that an empty window is restricted.

The loose files brought us in the direction of restricted windows. I personally like the concept. It's similar to 'Private browsing window' on browsers. But has different traits than 'restricted workspaces'.

  • 'restrictedness' is a window property and does not change

  • users can decide to open the same folder in restricted mode and in unrestricted mode. the recent history entries would reflect that. You could see the same input once with and without the [Restricted] tag.

  • we can add a top level menu File entry New Restricted Window

  • On 'Open Folder' we can still deduct based on the folder/workspace path whether to open a restricted or a normal window. But IMO that needs to be decided 'before' the window is opened (or before the window starts the ext host)

@lszomoru lszomoru added the workspace-trust Trusted workspaces label May 28, 2021
@sbatten sbatten added the bug Issue identified by VS Code Team member as probable bug label Jul 12, 2021
@sbatten sbatten added this to the July 2021 milestone Jul 12, 2021
@sbatten
Copy link
Member

sbatten commented Jul 12, 2021

I think the only remaining item to fix here is the capitalization.

@lszomoru
Copy link
Member

Workspace trust editor capitalisation fixed with 67565c0

@lszomoru
Copy link
Member

I have moved the throughs around restricted mode to #126050.

@rzhao271 rzhao271 added the verified Verification succeeded label Jul 28, 2021
@rzhao271
Copy link
Contributor

I still see the following

open a new window (restricted) , use Add folder to workspace, choose a folder that is trusted : the window is now suddenly unrestricted

I'm assuming more discussion on this is being tracked in #126050

The other parts LGTM

@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workspace-trust Trusted workspaces
Projects
None yet
Development

No branches or pull requests

4 participants