Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Notebooks - Drag and drop line in wrong spot #124408

Open
claudiaregio opened this issue May 22, 2021 · 1 comment
Open

Native Notebooks - Drag and drop line in wrong spot #124408

claudiaregio opened this issue May 22, 2021 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-dnd
Milestone

Comments

@claudiaregio
Copy link

Indicator for drag and drop movement in cells doesn't end up between cells when the insert cell items (+Code +Markdown) are in the notebook toolbar.

drag and drop indicator

@roblourens
Copy link
Member

@rebornix this is a tricky one. This is due to the extra 18px of padding that we put at the top of the editor for the top insertion toolbar (and it makes space so cell toolbars can overflow a little). Normally this is part of the height of each cell. Here, it should just be part of the height of the top cell. But, the cell VM doesn't know its index and I don't know a nice way to just change the height of the first cell for this. But here you have the cell toolbar overflow the previous cell, so the first one does need to be special. Any idea how to handle it?

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug notebook-dnd labels Oct 13, 2021
@roblourens roblourens added this to the Backlog milestone Oct 13, 2021
@rebornix rebornix removed their assignment Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug notebook-dnd
Projects
None yet
Development

No branches or pull requests

3 participants