Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Going from Static Preview to Text Editor Prompts User to Save #124132

Closed
andreamah opened this issue May 18, 2021 · 1 comment
Closed

Going from Static Preview to Text Editor Prompts User to Save #124132

andreamah opened this issue May 18, 2021 · 1 comment
Assignees
@andreamah
Labels
bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors) markdown Markdown support issues

Comments

@andreamah
Copy link
Contributor

andreamah commented May 18, 2021 •
edited

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.57 - insiders
  • OS Version: Windows

Related to #84520

Steps to Reproduce:

  1. Open .md file in text and switch to static preview custom editor without saving.
  2. When switching back, it asks the user to save. Not sure if this is expected behavior, since toggling between the two modes with an unsaved file should probably not be throwing errors?
    Alternatively, the expected behavior could simply be asking the user to save whenever switching to a custom editor?
@andreamah andreamah added bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues labels May 18, 2021
@andreamah andreamah self-assigned this May 18, 2021
@andreamah andreamah added the custom-editors Custom editor API (webview based editors) label May 18, 2021
@andreamah
Copy link
Contributor Author

Seems that the newest changes on main asks the users to save before transitioning to the custom editor. This is likely closer to expected behavior, so I will close this issue for now.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andreamah andreamah

Labels
bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors) markdown Markdown support issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andreamah