Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links Broken in Markdown Preview Custom Editor #118176

Closed
BeatLink opened this issue Mar 5, 2021 · 5 comments
Closed

Links Broken in Markdown Preview Custom Editor #118176

BeatLink opened this issue Mar 5, 2021 · 5 comments
Assignees
Labels
info-needed Issue requires more information from poster markdown Markdown support issues *not-reproducible Issue cannot be reproduced by VS Code Team member as described
Milestone

Comments

@BeatLink
Copy link

BeatLink commented Mar 5, 2021

  • VS Code Version: 1.53.2
  • OS Version: Linux Mint Cinnamon 20.1

Issue created in response to #84520 (comment)

Steps to Reproduce:

  1. Add the following code to your settings.json:
"workbench.editorAssociations": [
    {
        "viewType": "vscode.markdown.preview.editor",
        "filenamePattern": "*.md"
    }
]
  1. Start VSCode
  2. Open a markdown file with a link
  3. Click on the link
  4. Nothing Happens (preview page should navigate to the link)

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Mar 5, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@mjbvz mjbvz added this to the April 2021 milestone Mar 18, 2021
@mjbvz
Copy link
Contributor

mjbvz commented Apr 20, 2021

I just tested this but it seems to work for me. Can you please share an example where it does not work?

@mjbvz mjbvz added markdown Markdown support issues info-needed Issue requires more information from poster labels Apr 20, 2021
@oskude
Copy link

oskude commented Apr 23, 2021

markdown filesystem links like:

  • [foo](./foo/foo.md) (should open foo.md in the same preview tab)
  • [bar](./bar/bar.js)(should open bar.js in new editor tab)

worked yesterday* in the markdown preview, but not anymore with:

Version: 1.55.2
Commit: 3c4e3df9e89829dce27b7b5c24508306b151f30d
Date: 2021-04-22T15:03:39.218Z
Electron: 11.4.3
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Linux x64 5.11.16-arch1-1

*sorry, i don't keep package logs so dunno what my previous version was >.<

@oskude
Copy link

oskude commented Apr 23, 2021

seems to be fixed already in latest git mastermain (at time of writing: 6c747e7)

@mjbvz
Copy link
Contributor

mjbvz commented Apr 23, 2021

Closing. Let me know if there's a case that's not working

@mjbvz mjbvz closed this as completed Apr 23, 2021
@mjbvz mjbvz added the *not-reproducible Issue cannot be reproduced by VS Code Team member as described label Apr 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster markdown Markdown support issues *not-reproducible Issue cannot be reproduced by VS Code Team member as described
Projects
None yet
Development

No branches or pull requests

3 participants