New search editor should be pre-filled with selected text when pressing Ctrl + Shift + F

[Merlin2001]

I've been using the new "search.mode": "newEditor" setting as default lately and realized that it differs in an important way from "search.mode": "view":
In contrast to the search view, the search editor is not initialized with the selected text when pressing Ctrl + Shift + F.

Even more inconsistently, when setting "search.mode": "reuseEditor" the re-used editor is initialized with the selection (even ignoring the seedSearchStringFromSelection setting).

I think they should behave the same and potentially take into consideration #20768 so that Ctrl + F also behaves consistently.

I tested all combinations and they're a little inconsistent 🙈:

Pre-fill behavior legend:
0: Not pre-filled at all
1: Pre-filled with selection only
2: Pre-filled with selection or word the cursor is currently at (as criticized in #20768)

|  shortcut          |  seed..Selection |  search.mode  |  pre-fill behavior  |
|--------------------|------------------|---------------|---------------------|
|  Ctrl + F          |  false           |  irrelevant   |         0           |
|  Ctrl + F          |  true            |  irrelevant   |         2           |
|--------------------|------------------|---------------|---------------------|
|  Ctrl + Shift + F  |  false           |  view         |         0           |
|  Ctrl + Shift + F  |  false           |  reuseEditor  |         1 (!)       |
|  Ctrl + Shift + F  |  false           |  newEditor    |         0           |
|--------------------|------------------|---------------|---------------------|
|  Ctrl + Shift + F  |  true            |  view         |         1           |
|  Ctrl + Shift + F  |  true            |  reuseEditor  |         1           |
|  Ctrl + Shift + F  |  true            |  newEditor    |         0 (!)       |

[JacksonKearl]

Thanks for the detailed report!

|  Ctrl + Shift + F  |  true            |  newEditor    |         0 (!)       |

This is a duplicate of #115633 and is fixed in Insiders.

|  Ctrl + Shift + F  |  false           |  reuseEditor  |         1 (!)       |

This is a bug. (and I suspect false/newEditor may behave incorrectly here Insiders too now)

[JacksonKearl]

Fixed

|  Ctrl + Shift + F  |  false           |  reuseEditor  |         1 (!)       |

Left

|  Ctrl + Shift + F  |  false           |  newEditor  |         1 (!)       |

as-is, as there's no data loss to the new editor having a prefilled query.

[ghiscoding]

wow seriously, I know this new bug is a little frustrating (I see it too and that is why I'm tracking this issue) but wow just calm down, this is an Open Source project, if you want this bug fix then pull up your sleeves and fix it and stop bashing at the VSCode team. You're not paying a single penny for it, so why are you writing such harsh message?? As an Open Source library maintainer, I see message like yours and it just makes me want to quit sometime... the least you could do is be polite and wait for a fix, especially since you didn't pay neither contribute to the project... or just move to a paid software where you can expect more.

[JacksonKearl]

@AndrewDavis I understand your compliant and I'm sorry you had trouble with this. To clarify: this feature was newly released last iteration (1.53.0) as an opt-in to different search modes. One of those modes (newEditor) did not behave the same as the existing default when text was selected in the editor. This was fixed in Insiders and will be fixed in Stable in 1-2 weeks.

Based on your comments it appears that you opted-into this new behavior by setting the search.mode setting away from its default, the new behavior did not match your expectations, and opting back out by resetting the setting to its default value resolved this issue, is this correct?

I ask because it is not clear to me if you perhaps set this setting then forgot about it, or if this somehow got enabled by default -- the latter would be a severe bug I would need to look more in to, but I have not heard of any cases of that happening.