Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Editors file list jump (autoscroll) after closing an editor #115714

Closed
redtopia opened this issue Feb 3, 2021 · 13 comments
Closed

Open Editors file list jump (autoscroll) after closing an editor #115714

redtopia opened this issue Feb 3, 2021 · 13 comments
Assignees
Labels
feature-request Request for new features or functionality open-editors Issues related to the OPEN EDITORS view *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@redtopia
Copy link

redtopia commented Feb 3, 2021

When closing a tab, and your current editor is represented by a tab that's out of view, the tab bar will jump (auto-scroll) to reveal the tab for the current editor. This is a problematic behavior that also occurs when closing files found in the Open Editors pane.

A simple solution that I think will improve the UX would be to postpone the auto-scroll until after the user is no longer hovering over the tab bar (or the Open Editors pane). This would allow the user to close multiple tabs or editors without losing their place and having to scroll back.

@vscodebot
Copy link

vscodebot bot commented Feb 3, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@redtopia redtopia changed the title Tabs jump after closing one Tabs and Open Editors file list jump (autoscroll) after closing an editor Feb 3, 2021
@redtopia redtopia changed the title Tabs and Open Editors file list jump (autoscroll) after closing an editor Tabs and Open Editors file list jump (autoscroll) after closing an editor from either the tabs or the Open Editors list Feb 3, 2021
@isidorn
Copy link
Contributor

isidorn commented Feb 4, 2021

Assigning to @bpasero for the tab area
For the open editors to me - though we plan no changes there at the moment

@bpasero
Copy link
Member

bpasero commented Feb 4, 2021

Tabs is covered with: #40290

@bpasero bpasero removed their assignment Feb 4, 2021
@bpasero bpasero added the open-editors Issues related to the OPEN EDITORS view label Feb 4, 2021
@isidorn isidorn added the feature-request Request for new features or functionality label Feb 4, 2021
@isidorn isidorn added this to the Backlog milestone Feb 4, 2021
@bpasero bpasero changed the title Tabs and Open Editors file list jump (autoscroll) after closing an editor from either the tabs or the Open Editors list Open Editors file list jump (autoscroll) after closing an editor from either the tabs or the Open Editors list Feb 4, 2021
@redtopia
Copy link
Author

redtopia commented Feb 4, 2021

#40290 doesn't seem to be the same issue. The issue I'm reporting is that in some cases, the entire tab bar auto-scrolls as soon as you close a tab, making it impossible to close a bunch of tabs without re-scrolling back to where you were. This happens if the current editor is represented by a tab that is out of the visible tab area.

@bpasero
Copy link
Member

bpasero commented Feb 4, 2021

as soon as you close a tab

So how do you close the tab and what do you expect?

@redtopia
Copy link
Author

redtopia commented Feb 4, 2021

Let's say I am closing a bunch of editors because I just finished up some work. The current editor is represented by the far left tab. I scroll my tab bar over to the right, which reveals a bunch of tabs I want to close. The far left editor tab is no longer visible. I then close a tab and immediately the tab bar scrolls back to the far left to reveal the current editor's tab. Then I have to scroll all the way back to where I was in my tab bar to close the next window.

This same behavior can be seen in the Open Editors pane. If you scroll away from the current editor, and close a file in the list, the list will immediately scroll back to the reveal the current editor.

I realize that it's good to always show the current editor tab or open file. But this "always show" behavior can be postponed until after the user has moved their mouse out of the area where they are doing things. This way, I would be able to close a bunch of editors without having to keep scrolling between actions.

FYI, there is a workaround that I've gotten used to using, which is to change your current editor to be in the same visible location of the tabs (or open editor items) where you're doing things. But, this is a PIA in most cases.

@bpasero
Copy link
Member

bpasero commented Feb 4, 2021

@redtopia so how is #40290 not relevant then that would make sure the tabs stay where they are for as long as the mouse is over tabs? I assume this is using mouse?

@redtopia
Copy link
Author

redtopia commented Feb 4, 2021

@bpasero because #40290 has to do with keeping all the tabs the same size so you don't have to move your mouse when closing a bunch of adjacent tabs. This feature request has to do with not auto-scrolling the entire tab bar after closing a tab.

@redtopia
Copy link
Author

redtopia commented Feb 4, 2021

Here's a screenshot of the behavior:

screenshot

@bpasero
Copy link
Member

bpasero commented Feb 9, 2021

@redtopia fair, I have opened a new issue just for tabs: #116170

One thing that probably helps you is to configure workbench.editor.focusRecentEditorAfterClose: false

@bpasero bpasero changed the title Open Editors file list jump (autoscroll) after closing an editor from either the tabs or the Open Editors list Open Editors file list jump (autoscroll) after closing an editor Feb 9, 2021
@redtopia
Copy link
Author

redtopia commented Feb 9, 2021

Thanks @bpasero, that actually does help when closing an active tab, though it doesn't do anything with regard to this issue.

@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label May 4, 2021
@redtopia
Copy link
Author

redtopia commented May 4, 2021

I cannot understand why this issue would be closed. I run into this UX problem every single day in my workflow. Closing multiple editors is always a problem unless I pre-select an open editor that is in close proximity to the editors I want to close, and that only helps if the editors I want to close are grouped together. Why is nobody else complaining about this? Seems like a straightforward fix to postpone the auto-scrolling until after your mouse leaves either the tabs or the open editors pane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality open-editors Issues related to the OPEN EDITORS view *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

4 participants
@redtopia @bpasero @isidorn and others