Format on Save (prettier) stopped working with latest update #108447

ivanjeremic · 2020-10-10T12:11:32Z

Format on Save (prettier) stopped working with the latest update

Multiple time reinstalled Prettier, and checked the settings, it happened right after the update of VSCode.

https://gyazo.com/f07a3bfd0733edeed2a8d213fc3d21ac

nofear-js · 2020-10-10T13:28:03Z

Same problem

j-francisco · 2020-10-11T03:01:27Z

Same thing happened to me just now. I set prettier as the Default Formatter in Settings and it started working again. My Default Formatter was null.

frandmb · 2020-10-11T05:12:05Z

Worked for me, thank you!

pgmoir · 2020-10-11T16:28:41Z

Yes, it worked as default formatter, but surely I shouldn't have to set default formatter for vscode. It should be on a project by project basis.

jannomeister · 2020-10-12T06:56:58Z

This worked for me also but there's some scenarios where I just want prettier for a specific project and not globally 😢

nicolasrouanne · 2020-10-12T12:19:57Z

Same for me, selecting prettier as default formatter for VSCode works, but this prevents from working with other languages. I'm using ruby as well, and I've got the same problem with rubocop formatter: it stopped working as of 1.50.0.
And I can't have 2 different default formatters globally for VSCode.

AlissonRS · 2020-10-12T16:58:08Z

In case anyone is having issues finding the option @j-francisco explained above:

File -> Preferences -> Settings (for Windows)
Code -> Preferences -> Settings (for Mac)

Search for "Default Formatter". In the dropdown, prettier will show as esbenp.prettier-vscode.

MichelKansou · 2020-10-13T07:44:19Z

@AlissonRS Thx

iNishant · 2020-10-13T09:16:25Z

The above solution by @j-francisco and @AlissonRS fixes the prettier issue but for me, but all other language settings have been messed up too. For python, we use black formatter and now that's not working because I have selected prettier as the default formatter. If I select black as default then prettier won't work on js files. Seems like auto detect language and formatter is not working. Any idea how I could fix this?

madsh93 · 2020-10-13T10:22:35Z

I understand the frustation from people who are dependent on this. I use other tools such as Headwind, which now does not work.

kud · 2020-10-13T16:04:09Z

Same here. Is it a breaking change from VS Code or is it prettier which changed its namespace/code name?

ivanjeremic · 2020-10-13T17:07:34Z

I fixed it and now it broke again from alone, this has no effect #108447 (comment) Edit Fixed it again by directly searching Format on Save and activate it.

jrieken · 2020-10-15T08:49:39Z

So, what's the issue here? Is it that the settings (editor.defaultFormatter) isn't alive anymore? Or is it that the setting for format on save (which is off by default) (editor.formatOnSave) isn't set?

AlissonRS · 2020-10-15T09:04:52Z

@jrieken it's not related to editor.formatOnSave, the problem is prettier stopped working, even manual formatting (SHIFT + ALT + F) wasn't working, and it worked again after setting editor.defaultFormatter to prettier. What is not clear to me is if new VS Code just accidentally removed editor.defaultFormatter (updated it to null), or if editor.defaultFormatter has always been null but previous VS Code versions were able to handle it properly and still make prettier work.

jrieken · 2020-10-15T09:14:08Z

Yeah, that's the question. Out of the box, editor.defaultFormatter is null. Also, note that the setting can be configured per language - something the UI doesn't support and that needs the JSON-based editor

ivanjeremic · 2020-10-15T09:24:13Z

Both in my case, first the editor.defaultFormatte was null, after I fixed it one day later the (editor.formatOnSave) was not active anymore.

jrieken · 2020-10-15T09:39:11Z

@ivanjeremic Do you use settings sync?

ivanjeremic · 2020-10-15T09:40:05Z

Yes I do.

kud · 2020-10-15T09:42:44Z

I don't any settings sync and yeah my editor.defaultFormatter was null instead of esbenp.prettier-vscode. Maybe they changed their codename.

Anyway, here, since I set the right formatter, I'm good. 👍🏻

ap00rv · 2020-10-16T04:19:22Z

I am experiencing same behavior as @nicolasrouanne . If I set prettier as formatter in user settings, then only it works. If I set it only in workspace settings for my TS project, it does not work. This isn't ideal for people working on languages other than TS/JS.

jrieken · 2020-10-16T07:08:31Z

@ap00rv I have tried that and I cannot reproduce. I have prettier installed and configured to be the default formatter for typescript-files and format on save works for me.

{
    "editor.formatOnSave": true,
    "[typescript]": {
        "editor.defaultFormatter": "esbenp.prettier-vscode"
    }
}

Can you (or someone) share reproducible steps with me?

ap00rv · 2020-10-16T15:19:52Z

Hi @jrieken , can you try using the above settings only at workspace level ( default formatter in user setting should be null) and then see what happens ?

jrieken · 2020-10-16T15:25:30Z

Yeah, that's what I have.

ap00rv · 2020-10-16T16:36:24Z

ok, my apologies. It is working for me now after setting the following in workspace setting only . Sorry for the trouble.

"editor.codeActionsOnSave": {
      // For ESLint
      "source.fixAll.eslint": true
    },
    "[typescript]": {
      "editor.defaultFormatter": "esbenp.prettier-vscode"
    },

dlsso · 2020-10-16T18:01:17Z

All my coworkers and I are on VS Code 1.50.1 and Prettier extension 5.7.1, but some are seeing the issue and some not, so something else is at play here.

ap00rv · 2020-10-18T17:43:54Z

@dlsso for those of your colleagues facing issues, you may want to check if the default formatter setting in workspace is being overriden somewhere else. Thats what happened in my case. ESlint linting should be configured using different option as given here

lleonardoprado · 2020-11-10T14:12:33Z

Thank you, worked for me!

kdzapp · 2020-11-10T19:48:13Z

Thank you!! When prettier started working again I felt like I could breath again 😂

bnitin92 · 2020-11-12T04:36:41Z

Thank you for the setting, worked for me.

jahanner · 2020-11-12T21:57:48Z

@j-francisco Came in clutch, thanks

BenHurMartins · 2020-11-15T13:27:50Z

worked as a glove, thanks

parnekov · 2020-11-16T07:46:16Z

Put this fields to settings.json

"editor.defaultFormatter": "esbenp.prettier-vscode",
"[javascript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
}

参考：microsoft/vscode#108447 (comment) File -> Preferences -> Settings (for Windows) Code -> Preferences -> Settings (for Mac) Search for "Default Formatter". In the dropdown, prettier will show as esbenp.prettier-vscode.

IRediTOTO · 2020-11-19T04:33:36Z

Me too

juniordnts · 2020-11-19T22:27:11Z

I'm about to roll back to the working vscode. Now it's just buggy. In some directories it does format, in others just don't. I tried:

"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.formatOnSaveMode": "file"

This didn't work.

The funny thing is: In my node project any "format on save" work. But in my PHP project all format on all files works normaly.

PsionicChic · 2020-11-20T01:10:36Z

Here's what worked for me:
set Default Formatter to 'esbenp.prettier-vscode'
set Format On Save is checked and mode is 'file'
...
I also had to turn Auto-Save to 'off' <=== this is what made it happen for me

adelriosantiago · 2020-11-24T06:32:47Z

Just a reminder: If after setting the defaultFormatter to esbenp.prettier-vscode it still doesn't work. You may have an error in your JS/HTML. Take a look at the output (down-right part of the screen) as shown below to see which line is causing Prettier to fail.

deadlysyn · 2020-11-24T15:54:18Z

My biggest problem is after setting a defaultFormatter, anything not formatted with Prettier (Go, Terraform, etc) throws "prettier can't format this file". It's odd to me that this all worked great for years, but now breaks...and even the workarounds are fragile...but this isn't a regression. I need to spend the weekend going through settings with a fine toothed comb. :-(

mddilley · 2020-11-24T19:09:11Z

I struggled with this issue as well when formatting on save with Prettier for JS and Black for Python. These settings used to coexist great but something changed. I had success by setting editor.defaultFormatter per language in my settings.json. Switching default each time I worked on a different codebase was not ideal, so this made me very happy.

{
  <all the other stuff>,
  "editor.formatOnSave": true,
  "python.formatting.provider": "black",
  "python.formatting.blackPath": "black",
  "[javascript]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "[python]": {
    "editor.defaultFormatter": null
  },
}

deadlysyn · 2020-11-25T02:42:53Z

Thank you for sharing @mddilley -- this will save my sanity, but also find the need for so much more configuration just to maintain prior behavior infuriating. Was there a technical reason for this change? Someone thought it was good DevEx? Curious minds want to know.

szobonyatomi · 2020-11-25T16:00:28Z

no work with php, (html, css OK)

xavierhazzardadmin · 2020-12-02T09:30:39Z

This didn't work for me

wyeo · 2020-12-04T09:35:12Z

@xavierhazzardadmin look inside your settings.json file :

Windows : %APPDATA%\Code\User\settings.json
macOS : $HOME/Library/Application Support/Code/User/settings.json
Linux : $HOME/.config/Code/User/settings.json

harukaeru · 2020-12-10T13:35:37Z

Perhaps it was only to me, but it happened because I'd forgotten to lay .prettierrc at the top-level. As @adelriosantiago mentioned, you can see logs as follows.

Once I lay the config file properly, it was all fixed.
Yeah, if there were no config, prettier can't know how to prettify my codes... I was dumb.

deadlysyn · 2020-12-11T17:25:53Z

@paullewisn i'm no expert, just someone who finds it infuriating when i need to spend a week re-configuring a "tool" that's supposed to help make me productive :-) so maybe something in this will help you... if you haven't already, try a few things (some as a direct fix, some to prevent other problems):

ctrl-, and make sure "editor: default formatter" setting is null. this is so the explicit ones you specify are in full control with no surprises. unless you only work in one language, whatever you set this to will be wrong in some files and cause confusion.

double check "Editor: Format On Save" is checked while in settings, it should be per your settings.json. trust byt verify.

adjust "Editor: Format On Save Mode" -- some have reported it only works properly when set to "file".

in settings.json, make sure files.autoSave is off. this is called out in "Format on Save" setting description and some plugin readmes.

if it still doesn't work after all that, consider having vscode run eslint, and eslint in turn call prettier...this gets the best of both tools and has ran w/o problems for years (minus the default formatter changes that broke the whole chain). if you go this route, you'll need a small amount of config for each tool + appropriate project dependencies installed. there are a lot of online articles to help with that, here's one:

https://dev.to/thetinygoat/prettier-eslint-setup-for-vscode-5b6

good luck!

appyofficial · 2020-12-14T19:37:59Z

Worked!!! 🍡

deadlysyn · 2020-12-14T20:14:53Z

@appyofficial that will work great, until you try to work in a file prettier doesn't handle... keeping default null and having per-language settings is required if you work in languages not supported by prettier. otherwise things like terraform, go, etc. will get errors on each save about unsupported formatter.

if this works for you, great... KISS. :-)

Redskinsjo · 2020-12-18T19:08:17Z

How do you configure the config files ?

It says to me

should i create a .prettierrc file at the root of my project and set some of the properties suggested ?? but which ?

deadlysyn · 2020-12-18T19:56:27Z

@Redskinsjo that will be somewhat personal-preference/project specific, but you can start with something like:

# .prettierrc
{
  "printWidth": 80,
  "singleQuote": true,
  "tabWidth": 2,
  "semi": false
}

# .prettierignore
package.json
package-lock.json

then extend as needed:

https://prettier.io/docs/en/configuration.html

Redskinsjo · 2020-12-18T20:17:23Z

i created a .prettierrc and a .prettierignore file at the root of my project, but Prettier still doesn't work.

harikrishnan-u01 · 2020-12-20T20:01:00Z

Worked for me. Thanks a lot.

vscode-triage-bot assigned jrieken Oct 10, 2020

jrieken added formatting Source formatter issues info-needed Issue requires more information from poster labels Oct 15, 2020

jrieken mentioned this issue Oct 15, 2020

no format on paste/save on v 1.50.0 #108365

Closed

imnasnainaec mentioned this issue Nov 12, 2020

Add explicit default formatters by language sillsdev/TheCombine#808

Merged

gjsjohnmurray mentioned this issue Nov 15, 2020

Save options #110654

Closed

d3dc mentioned this issue Dec 6, 2020

ESLint, Prettier no longer work #111966

Closed

This comment has been minimized.

Sign in to view

github-actions bot locked and limited conversation to collaborators Dec 24, 2020

Format on Save (prettier) stopped working with latest update #108447

Format on Save (prettier) stopped working with latest update #108447

Comments

ivanjeremic commented Oct 10, 2020

nofear-js commented Oct 10, 2020

j-francisco commented Oct 11, 2020

frandmb commented Oct 11, 2020

pgmoir commented Oct 11, 2020

jannomeister commented Oct 12, 2020

nicolasrouanne commented Oct 12, 2020

AlissonRS commented Oct 12, 2020 • edited

MichelKansou commented Oct 13, 2020

iNishant commented Oct 13, 2020

madsh93 commented Oct 13, 2020

kud commented Oct 13, 2020

ivanjeremic commented Oct 13, 2020 • edited

jrieken commented Oct 15, 2020

AlissonRS commented Oct 15, 2020 • edited

jrieken commented Oct 15, 2020

ivanjeremic commented Oct 15, 2020

jrieken commented Oct 15, 2020

ivanjeremic commented Oct 15, 2020

kud commented Oct 15, 2020

ap00rv commented Oct 16, 2020

jrieken commented Oct 16, 2020

ap00rv commented Oct 16, 2020

jrieken commented Oct 16, 2020

ap00rv commented Oct 16, 2020

dlsso commented Oct 16, 2020 • edited

ap00rv commented Oct 18, 2020

lleonardoprado commented Nov 10, 2020

kdzapp commented Nov 10, 2020

bnitin92 commented Nov 12, 2020

jahanner commented Nov 12, 2020 • edited

BenHurMartins commented Nov 15, 2020

parnekov commented Nov 16, 2020

IRediTOTO commented Nov 19, 2020

juniordnts commented Nov 19, 2020

PsionicChic commented Nov 20, 2020

adelriosantiago commented Nov 24, 2020

deadlysyn commented Nov 24, 2020

mddilley commented Nov 24, 2020 • edited

deadlysyn commented Nov 25, 2020

szobonyatomi commented Nov 25, 2020

xavierhazzardadmin commented Dec 2, 2020

wyeo commented Dec 4, 2020 • edited

harukaeru commented Dec 10, 2020

deadlysyn commented Dec 11, 2020

appyofficial commented Dec 14, 2020

deadlysyn commented Dec 14, 2020

Redskinsjo commented Dec 18, 2020

deadlysyn commented Dec 18, 2020

Redskinsjo commented Dec 18, 2020

This comment has been minimized.

harikrishnan-u01 commented Dec 20, 2020

AlissonRS commented Oct 12, 2020 •

edited

ivanjeremic commented Oct 13, 2020 •

edited

AlissonRS commented Oct 15, 2020 •

edited

dlsso commented Oct 16, 2020 •

edited

jahanner commented Nov 12, 2020 •

edited

mddilley commented Nov 24, 2020 •

edited

wyeo commented Dec 4, 2020 •

edited