Problems pane ignores "Hide Excluded Files" option

[Sergej-Popov]

• VSCode Version: 1.47.2
• OS Version: Windows 10 (2004)

Steps to Reproduce:

1. Create a dotnet project
2. Add **\obj & **\bin to settings.json files.exclude
3. Open a problems pane and check "Hide Excluded Files"
4. Build and open problems

Expected: problems pane not to show problems in generated code in **\obj folder.
Actual: all problems are still visible under problems pane but as expected not visible in the explorer.

Does this issue occur when all extensions are disabled?: No, the "problems" are generated by an extension. So cannot reproduce this way.

Related issue: #22289

[gjsjohnmurray]

AFAIK the feature in Problems to exclude items uses its own filter, which you must enter in the field to the left of the filter button. I don't think it pays any attention to files.exclude

[Sergej-Popov]

This comment suggests that files.exclude suppose to work: #22289 (comment)

While I can use the Filter on the left, it is separate from "Hide Excluded Files" option. They don't interact.

[gjsjohnmurray]

Deferring to @sandy081

[Sergej-Popov]

Clarification with regards to

vscode/src/vs/workbench/contrib/files/browser/views/explorerViewer.ts

Lines 509 to 513 in 42a9a99

	/**
	* Respectes files.exclude setting in filtering out content from the explorer.
	* Makes sure that visible editors are always shown in the explorer even if they are filtered out by settings.
	*/
	export class FilesFilter implements ITreeFilter<ExplorerItem, FuzzyScore> {

Problems are always visible not only when the file is open in the editor. I opened one in the screenshot just to show the error, but others that aren't open in the editor are still visible in the Problems pane too.

[ghost]

Oh alright, I realized I misunderstood so that is why I deleted my comment. I apologize for any confusion. Lemme see if I can figure something out today

[ghost]

Hi upon further investigation it appears that this feature uses a different list. I believe that it goes off of this list found in settings. But I do also acknowledge #22289. @sandy081 could you maybe give me some input here? Maybe it can use both the global setting and the setting.json option together?

[LC43]

this also happens with php language server.
is there a

"php.problems.exclude" : {
        "node_modules/**" : true,
    },

of some sort, like devsense extension has?

I have to disable "php.validate.executablePath": "/aaaa", altogether because "php.validate.enable": false, doesn't stop vscode to fill Problems pane.

[gjsjohnmurray]

@Sergej-Popov I wasn't able to reproduce this issue when I tested just now on 1.52.1. Problems reported on a file whose name matched a glob in files.exclude disappeared from the panel when I selected the "Hide Excluded Files" filter. They reappeared when I deselected that filter option, or when I removed or disabled the files.exclude entry.

If the problem still exists for you please provide simple repro steps.

[sandy081]

@gjsjohnmurray Very much appreciated for validating the issue again.

@Sergej-Popov Please provide exact steps to repro.

[Sergej-Popov]

Hey @sandy081 @gjsjohnmurray I did a repro on a clean machine and I know exactly what the issue is now.

It has to do with how glob pattern is applied in the problems pane.
If you apply it on folder like this - it does not work for problems pane, but works in explorer view.

{
    "files.exclude": {
        "**/test": true
    }
}

If you apply it on all files inside the folder - it works for problems pane and explorer view.

{
    "files.exclude": {
        "**/test/**": true
    }
}

I was able to reproduce this behaviour in typescript solution too, so dotnet was a red herring.

[sandy081]

Thanks for the repro. Will investigate in February.

[jeanp413]

Pushed a PR #119040 with a possible fix