Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working when a VSCode Workspace has Multiple Repos #1111

Closed
mainawycliffe opened this issue Apr 8, 2019 · 7 comments
Closed

Not working when a VSCode Workspace has Multiple Repos #1111

mainawycliffe opened this issue Apr 8, 2019 · 7 comments
Labels
bug Issue identified by VS Code Team member as probable bug upstream/vscode

Comments

@mainawycliffe
Copy link

mainawycliffe commented Apr 8, 2019

Before the April VSCode Update, I was able to to create pull request for my multi-repository workspace. But since then, the extension is always focused on the first repository and changing it under source control has no effect.
Before, you could change the repository under which to create a pull request by choosing one of your git repos, under Source Control in the activity bar, not the most intuitive approach but it worked. This no longer works.

  • Extension version: 0.6.0
  • VSCode Version: 1.33.0
  • OS: Windows 10

Steps to Reproduce:

  1. Update to the latest version of VSCode
  2. Open a VSCode Workspace with Multiple Repos
  3. Try creating a pull request on any repo other than the first
@upugo-dev
Copy link

I am also experiencing this issue. I've got an organisation github account, with multiple repos, each cloned into a vscode workspace. Only the first repo in the alphabetically-sorted list under Source Control Providers is available to the PR extension. Switching the focused repo in the Source Control Provider does not affect what PRS are available/visible in the Github PR extension.

  • Windows 10 Home
  • VSCode 1.33.0
  • GitHub Pull Requests extension 0.6.0

@RMacfarlane
Copy link
Contributor

Thanks for reporting this! It looks like the git extension is not sending a selection change event when it should be. I'm creating a PR to fix this now.

@RMacfarlane
Copy link
Contributor

I've just checked in the change in VSCode, so the fix should be available in tomorrows VSCode Insider's.

@upugo-dev
Copy link

I've just checked in the change in VSCode, so the fix should be available in tomorrows VSCode Insider's.

Awesome, thanks! Whats it looking like for the fix to be pulled in to the stable build?

@RMacfarlane
Copy link
Contributor

Based on microsoft/vscode#71830, the next stable build won't be until after May 10th

@upugo-dev
Copy link

@RMacfarlane ok thanks, not too long to wait. Cheers

@RMacfarlane
Copy link
Contributor

Closing this since the fix is now available in Insiders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug upstream/vscode
Projects
None yet
Development

No branches or pull requests

3 participants