Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conform to the recommendation in the standard for the socket argument, which is currently --socket instead of --port #1364

Open
RobbyCBennett opened this issue Nov 15, 2023 · 1 comment
Labels
feature-request Request for new features or functionality
Milestone

Comments

@RobbyCBennett
Copy link

RobbyCBennett commented Nov 15, 2023

Under Implementation Considerations in the LSP spec, the following arguments are laid out as highly recommended ways to standardize the CLI of starting a language server.

LSP:
stdio: (Unclear, but probably the default behavior without the pipe or socket arguments.)
pipe: The pipe / socket file name is passed as the next arg or with --pipe=.
socket: The port is passed as next arg or with --port=.

vscode-languageserver-node:
stdio: --stdio
pipe: --pipe=
socket: --socket=

This repository conforms for stdio and pipe, but not for socket.

@RobbyCBennett RobbyCBennett changed the title Conform to the recommendation in the standard for the socket argument with --socket Conform to the recommendation in the standard for the socket argument, which is currently --socket instead of --port Nov 15, 2023
@RobbyCBennett
Copy link
Author

Alternatively, because VS Code is so popular, we could change the recommendation in the LSP spec to be --socket= instead. The goal of this issue is to make the arguments in the LSP and vscode-languageserver-node consistent.

@dbaeumer dbaeumer added the feature-request Request for new features or functionality label Dec 5, 2023
@dbaeumer dbaeumer added this to the Backlog milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants