VS Code Fails to Save

[eric-mc2]

Issue Type: Bug

This happens often when editing a Jupyter notebook.

Steps:

1. Open and edit an .ipynb file with the Jupyter extension enabled.
2. Save the file.
3. Open the integrated source control panel, make some commits, view a diff, close the diff view. (I think the interaction with the diff view causes the problem).
4. Continue editing the .ipynb.
5. Ctrl+S or File->Save As.

Observed:
Current changes in the editor are not written to disk. Save-As writes the file's previously saved state to disk. No error is shown.

Related:
This doesn't duplicate microsoft/vscode#114588 which is specific to untitled files. Might duplicate microsoft/vscode#126561.

VS Code version: Code 1.57.1 (507ce72a4466fbb27b715c3722558bb15afa9f48, 2021-06-17T13:28:32.912Z)
OS version: Darwin x64 20.5.0
Restricted Mode: No

Extensions (15)

Extension	Author (truncated)	Version
mdmath	goe	2.7.4
latex-workshop	Jam	8.19.2
python	ms-	2021.6.944021595
vscode-pylance	ms-	2021.6.3
jupyter	ms-	2021.6.999662501
vscodeintellicode	Vis	1.2.14

[claudiaregio]

Hi @eric-mc2, could you please provide the Jupyter output content when the issue occurs?
Do you know if you are working with the Native Notebook interface? If you are unsure pasting a screenshot of your notebook would help us determine that.

[eric-mc2]

Hi @claudiaregio,
I can consistently reproduce the issue. It seems to be triggered by saving the working version while the diff is open. I'm not sure which interface I'm using. The screenshot has more detailed steps (the final 2 cells in the screenshot were lost when I closed the file).

jupyter-output.txt

[claudiaregio]

@eric-mc2 This should be fixed when we migrate to the native notebook interface completely. Does it work if you click the save button in the notebook toolbar or if you close the diff and try to save?

[greazer]

Thanks for your feedback. This issue is addressed with new native support for editing notebooks. To opt into that experience see: https://github.com/microsoft/vscode-jupyter/wiki/Introducing-Native-Notebooks.