Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error compiling test-provider-sample executionCount does not exist on type StatementCoverage #979

Closed
warent opened this issue Mar 4, 2024 · 3 comments · Fixed by #1011
Closed
Assignees

Comments

@warent
Copy link

warent commented Mar 4, 2024

Extension sample

test-provider-sample

VS Code version

1.87.0

What went wrong?

Following the instructions here https://code.visualstudio.com/api/language-extensions/language-server-extension-guide

It says the steps to get this running are:

> git clone https://github.com/microsoft/vscode-extension-samples.git
> cd vscode-extension-samples/lsp-sample
> npm install
> npm run compile
> code .

When I get to the compile step, it succeeds for a while but eventually hits an error and seems to abort

=== Running compile on test-provider-sample ===

> test-provider-sample@0.0.1 compile
> tsc -p ./

src/extension.ts:99:15 - error TS2339: Property 'executionCount' does not exist on type 'StatementCoverage'.

99      lineInfo.executionCount++;
                 ~~~~~~~~~~~~~~

I've tried this with both Node 18 and 20

@dbaeumer dbaeumer self-assigned this Mar 4, 2024
@dbaeumer dbaeumer added the info-needed Issue requires more information from poster label Mar 4, 2024
@dbaeumer dbaeumer assigned connor4312 and unassigned dbaeumer Mar 4, 2024
@dbaeumer dbaeumer removed the info-needed Issue requires more information from poster label Mar 4, 2024
@dbaeumer
Copy link
Member

dbaeumer commented Mar 4, 2024

Not about lsp-sample.

@connor4312
Copy link
Member

This'll be fixed as we finalize test coverage

@StErMi
Copy link

StErMi commented Apr 18, 2024

Hi there, I'm using the https://github.com/microsoft/vscode-extension-samples/blob/main/test-provider-sample as the base of my extension, and I'm getting the same error.

is it because the example should be updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants