Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lsp-embedded-language-service example (potentially) missing activation event #952

Open
BB-301 opened this issue Feb 6, 2024 · 0 comments
Open

lsp-embedded-language-service example (potentially) missing activation event #952

BB-301 opened this issue Feb 6, 2024 · 0 comments
Assignees
@aeschli

Comments

@BB-301
Copy link

BB-301 commented Feb 6, 2024

Extension sample

lsp-embedded-language-service

VS Code version

1.86.0

What went wrong?

Tried to run the demo as indicated here, but extension was not loading.

Adding onLanguage:html1 to activationEvents in package.json solved the problem for me.
@BB-301 BB-301 mentioned this issue Feb 6, 2024
Open
apupier added a commit to apupier/vscode-extension-samples that referenced this issue Mar 7, 2024
@apupier
Add activation event on language
540940e 
fixes microsoft#952

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
This was referenced Mar 7, 2024
Closed
Merged
@dbaeumer dbaeumer assigned aeschli and unassigned dbaeumer May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add activation event on language apupier/vscode-extension-samples
3 participants
@dbaeumer @aeschli @BB-301