Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging webview-codicons-sample doesn't package the codicons #692

Open
Tommycore opened this issue Jul 28, 2022 · 4 comments · May be fixed by #1005
Open

Packaging webview-codicons-sample doesn't package the codicons #692

Tommycore opened this issue Jul 28, 2022 · 4 comments · May be fixed by #1005
Assignees

Comments

@Tommycore
Copy link

Steps to reproduce:

  • Clone repo.
  • Open webview-codicons-sample folder with VS Code.
  • Run npm i.
  • Install packaging cli via npm i -g vsce.
  • Remove publisher line from package.json (otherwise you'll get the error message It's not allowed to use the 'vscode-samples' publisher.).
  • Run vsce package.
  • Go to the extensions tab and install the freshly created .vsix file.
  • Run the command Cat Codicons: Show Cat Codicons.

The result (at least for me), was a tab looking like this:
image

I opened the .vsix file manually and looked inside - and the codicons are nowhere to be found inside. Which begs the question: What am I missing when it comes to packaging? How would I best go about it with a project created with the yeoman generator as described in the official tutorials? Just add !node_modules/@vscode/codicons/dist/** to the .vscodeignore file?

@dacort
Copy link

dacort commented Oct 19, 2022

@Tommycore Ever figure this out? Running into the same.

@Tommycore
Copy link
Author

I can't really remember to be honest. Did adding the line to the .vscodeignore file work? If so I probably opened this issue to point out that the documentation is lacking and that I am unsure what the preferred way is.

@dacort
Copy link

dacort commented Oct 20, 2022

No worries, thanks for the reply! I did try that and it seems to work...specified just the css and ttf files to keep the size down.

!node_modules/@vscode/codicons/dist/codicon.css
!node_modules/@vscode/codicons/dist/codicon.ttf

@phil294
Copy link

phil294 commented Apr 15, 2024

Will most likely be fixed with #1005: The dependency in package.json is currently listed in the wrong place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants