Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Docker build to keep history of the image:tag that the user has specified for a Dockerfile #93

Closed
sajayantony opened this issue Jun 8, 2017 · 5 comments

Comments

@sajayantony
Copy link

sajayantony commented Jun 8, 2017

Users currently have to retype the tag specified during build if the tag is not of the form {folder}:latest.
Enabling a history of the tags currently built for a file would enable the user to simply rebuild the docker file without having to retype this over again ..

For e.g. If the user runs docker build with a image:tag as shown below the expectation is that the extension remembers this 😀
image

As part of the dev inner loop it would nice if rebuild can keep history of tag instead of the default -> Also might be worth considering deriving the tag from the file extension.

image

@lostintangent
Copy link
Member

I like this suggestion!

@jgainfort
Copy link

jgainfort commented Aug 18, 2017

Another suggestion that is similar to this is to add --rm to the build command to remove intermediate and none images after a successful build. Reason is current docker build command using the same tag name pushes the previous tag to have a tag of none.

@chrisdias
Copy link
Member

@jgainfort i created #111

PRs much appreciate everywhere!

@StephenWeatherford
Copy link
Contributor

@sajayantony We currently show the last-used tag as the default value when you go to build. I assume this takes care of this issue, right?

@sajayantony
Copy link
Author

Yep it retains the tag information.

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants