Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Empty PORT EXPOSE By Design #391

Closed
gngchrs opened this issue Aug 22, 2018 · 3 comments · Fixed by #490
Closed

Is Empty PORT EXPOSE By Design #391

gngchrs opened this issue Aug 22, 2018 · 3 comments · Fixed by #490
Labels
Milestone

Comments

@gngchrs
Copy link

gngchrs commented Aug 22, 2018

I was generating a Dockerfile with the > Dockerfile command, and decided to leave the PORT section as an empty string, as I'm generating a base image that doesn't require exposing. This is what is generated
screen shot 2018-08-22 at 14 37 00

I know it's as easy as just deleting the last line, but I'm wondering if this is by design, or if someone doesn't specify a port, EXPOSE should not be generated.

@StephenWeatherford StephenWeatherford added this to the 0.3.0 milestone Aug 22, 2018
@StephenWeatherford
Copy link
Contributor

Ideally we will not add the EXPOSE if port is empty.

@StephenWeatherford
Copy link
Contributor

Need to deal with compose files, too.

@PrashanthCorp PrashanthCorp modified the milestones: 0.6.0, 0.7.0 Feb 26, 2019
@PrashanthCorp PrashanthCorp added wontfix and removed P3 labels Mar 27, 2019
@PrashanthCorp
Copy link
Contributor

PrashanthCorp commented Mar 27, 2019

Moving forward we won't be generating dockerfiles with empty expose statements. It's easy to delete them manually.

@ejizba ejizba modified the milestones: 0.7.0, 0.6.0 May 8, 2019
@ejizba ejizba added bug and removed wontfix labels May 8, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators May 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants