Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attaching shell does not focus terminal #2413

Closed
dschuessler opened this issue Oct 16, 2020 · 5 comments · Fixed by #2421
Closed

Attaching shell does not focus terminal #2413

dschuessler opened this issue Oct 16, 2020 · 5 comments · Fixed by #2421

Comments

@dschuessler
Copy link

dschuessler commented Oct 16, 2020

Steps to reproduce on macOS:

  1. Start up some Docker container that runs indefinitely.
  2. Shift+Cmd+P (or whatever opens the command picker on other systems besides macOS)
  3. Select "Docker Containers: Attach Shell"
  4. Select the container

Expected behavior: A terminal is opened and I can type in it right away.
Actual behavior: A terminal is opened but it is out of focus. I have to click on the terminal to be able to type in it.

Other commands that open a terminal (like "Debug: Create Javascript Debug Terminal") focus it per default.

@bwateratmsft
Copy link
Contributor

I'm not able to reproduce the issue, what has focus in the bottom pane when it happens for you?

@jeroendk
Copy link

Got the same issue. When the focus is on the code editor before opening, the code editor keeps the focus. When I have another terminal focused, the focus completely disappears.

@bwateratmsft
Copy link
Contributor

Ok, with my cursor in the text editor window, focus stayed there. I'll take a look.

@bwateratmsft
Copy link
Contributor

I found the root cause and the fix should be quite simple.

@bwateratmsft
Copy link
Contributor

This fix has now been released in 1.8.0.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants