You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Updating the baseline in vcpkg-configuration.json ignores the reference. If another commit in the repository is newer. even in another branch (or only main?) it is used.
See the line "updated registry 'https://github.com/TheCycoONE/vcpkg-registry': baseline '15529ddf98c6ae963861c7fdc145c969d666aadf' -> '7e2920647c0c00b21d684c887d2c9b375a1b5b32'"
Expected behavior
It should respect the reference. The commit starting 15529dd is the head of that branch and does not need changing.
Additional context
The alternative I have is below, but I think x-updatebaseline` should do this by default, as it's the least surprising option. Switching to another reference (ie changing branch to main) should be behind an option.
The Git reference used to list available versions of a Git Registry. A string. Optional. If not specified, defaults to HEAD. This field can be a topic branch to access versions that are not yet fully published.
It sounds like reference is used here to identify an alternative version, in another branch. The git rev-parse command needs the reference if it exists, or HEAD.
I switched to branch lua_cmake, then used command git rev-parse HEAD to get the latest commit of that branch, the value is 15529ddf98c6ae963861c7fdc145c969d666aadf. I checked the code on the vcpkg-tool, and it seems that the case where the keyword reference is a branch is not handled. I have temporarily marked this issue as Vcpkg bug.
Describe the bug
Updating the baseline in vcpkg-configuration.json ignores the reference. If another commit in the repository is newer. even in another branch (or only main?) it is used.
Environment
Not OS specific
To Reproduce
Steps to reproduce the behavior:
vcpkg x-update-baseline --dry-run
Expected behavior
It should respect the reference. The commit starting 15529dd is the head of that branch and does not need changing.
Additional context
The alternative I have is below, but I think
x-update
baseline` should do this by default, as it's the least surprising option. Switching to another reference (ie changing branch to main) should be behind an option.edit: I don't know this program or cpp, but should HEAD be here? https://github.com/microsoft/vcpkg-tool/blob/main/src/vcpkg/configuration.cpp#L695
The text was updated successfully, but these errors were encountered: