Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile echo and python errors #111

Open
adityathakekar opened this issue Dec 17, 2022 · 1 comment
Open

Makefile echo and python errors #111

adityathakekar opened this issue Dec 17, 2022 · 1 comment

Comments

@adityathakekar
Copy link

  • uf2-version.h
    Echo Generates "#define UF2_VERSION_BASE "v3.14.0-5-g779ccde-dirty""
    instead of #define UF2_VERSION_BASE "v3.14.0-5-g779ccde-dirty"
  • Pull request submitted with changes.
  • python2 and python3 commands are not identified.
    changed to python, line numbers 177 and 187.
  • In order to create a uf2-version.h
    Create a build folder. build/zero.
@davepruitt
Copy link

I had these exact same issues previously. They didn't write their makefile in a Windows-friendly manner, which is somewhat surprising given that they are Microsoft. But oh well.

Your changes pretty much match exactly what I also had to do to get the makefile to work on Windows. You may also consider changing how the "mkdir" command is called, and that way you won't have to create the "build" folder yourself.

I outline everything that I did in my response to this person's post on the adafruit fork:

adafruit#196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants