Skip to content
This repository has been archived by the owner on Jun 11, 2020. It is now read-only.

testDependencies should include only top-level package names #517

Open
ghost opened this issue Nov 15, 2018 · 1 comment
Open

testDependencies should include only top-level package names #517

ghost opened this issue Nov 15, 2018 · 1 comment
Assignees
@sandersn

Comments

@ghost
Copy link

ghost commented Nov 15, 2018

Currently react's testDependencies includes "react-dom/server"; this should just be "react-dom".
@ghost ghost assigned sandersn Nov 15, 2018
@jablko
Copy link
Contributor

jablko commented Apr 21, 2020

I think this was fixed in #710: 85b12f6#diff-0249a3e9c640d0ab97518bf7114cfb67R357

I confirmed that in 85b12f6^'s output, react's testDependencies contain react-dom/server and in 85b12f6's output they do not.

@jablko jablko mentioned this issue Sep 2, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandersn sandersn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove internal paths from test dependencies jablko/DefinitelyTyped-tools
2 participants
@jablko @sandersn