Skip to content
This repository has been archived by the owner on Jun 11, 2020. It is now read-only.

Scoped & versioned packages can't pass path mappings checks #506

Open
jkillian opened this issue Oct 29, 2018 · 0 comments · May be fixed by #507
Open

Scoped & versioned packages can't pass path mappings checks #506

jkillian opened this issue Oct 29, 2018 · 0 comments · May be fixed by #507

Comments

@jkillian
Copy link

jkillian commented Oct 29, 2018

In DefinitelyTyped/DefinitelyTyped#29979, I was trying to create a new major version of a scoped package. In order to do that, you're supposed to add a path mapping similar to the example in the DefinitelyTyped readme:

        "paths": {
            "history": [ "history/v2" ]
        },

For the package I was trying to update, I believe that'd be:

        "paths": {
            "@expo/vector-icons": [ "expo__vector-icons/v6" ]
        },

However, the code here doesn't strip the version info and enforces that the mapping match the dependency name once unmangled. This means I'd have to write something like the following (which is incorrect):

        "paths": {
            "@expo/vector-icons": [ "expo__vector-icons" ]
        },

Would a PR be accepted to change this behavior?

@jkillian jkillian changed the title Scoped & versioned packages can't pass path mappings Scoped & versioned packages can't pass path mappings checks Oct 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant