Skip to content
This repository has been archived by the owner on Jun 11, 2020. It is now read-only.

URL in README of typing packages #465

Open
FranklinYu opened this issue May 21, 2018 · 1 comment
Open

URL in README of typing packages #465

FranklinYu opened this issue May 21, 2018 · 1 comment

Comments

@FranklinYu
Copy link

For example, @types/lodash says

Files were exported from https://github.com/DefinitelyTyped/DefinitelyTyped.git/tree/master/types/lodash

Note the .git extension. That URL is a 404. Correct URL is https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/lodash. The line is generated in

https://github.com/Microsoft/types-publisher/blob/e40d8bcd9fa7eaf330b195f7a22110a6f1c0d454/src/lib/package-generator.ts#L163

So typing.sourceRepoURL seems to have the .git extension, while it shouldn't be. The typing information tracks to PackageBase.sourceRepoURL, which is assigned in

https://github.com/Microsoft/types-publisher/blob/e40d8bcd9fa7eaf330b195f7a22110a6f1c0d454/src/lib/packages.ts#L182-L186

But BaseRaw.sourceRepoURL says that .git extension should not be there in the first place:

https://github.com/Microsoft/types-publisher/blob/e40d8bcd9fa7eaf330b195f7a22110a6f1c0d454/src/lib/packages.ts#L165-L166

@mhegazy
Copy link
Contributor

mhegazy commented May 21, 2018

A PR would be appreciated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants