Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overrideable resample property for IntersectionDataset #2012

Closed
robmarkcole opened this issue Apr 19, 2024 · 0 comments · Fixed by #2015
Closed

Overrideable resample property for IntersectionDataset #2012

robmarkcole opened this issue Apr 19, 2024 · 0 comments · Fixed by #2015
Labels
datasets Geospatial or benchmark datasets
Milestone
0.6.0

Comments

@robmarkcole
Copy link
Contributor

robmarkcole commented Apr 19, 2024 •
edited

Summary

IntersectionDataset performs nearest resampling by default which does not always give a desirable result. This FR is to add the ability to override this behaviour

Rationale

No response

Implementation

Add an overrideable resample property (similar to dtype) that changes resampling to bilinear for float32 and nearest for long. Then pass this into rasterio.merge.merge here

Alternatives

No response

Additional information

No response
@adamjstewart adamjstewart added this to the 0.6.0 milestone Apr 19, 2024
@adamjstewart adamjstewart added the datasets Geospatial or benchmark datasets label Apr 19, 2024
@adamjstewart adamjstewart mentioned this issue Apr 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
datasets Geospatial or benchmark datasets
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

RasterDataset: add control over resampling algorithm adamjstewart/torchgeo
2 participants
@robmarkcole @adamjstewart