Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero mask in ISPRS Potsdam #1727

Open
mizoru opened this issue Nov 13, 2023 · 6 comments
Open

Zero mask in ISPRS Potsdam #1727

mizoru opened this issue Nov 13, 2023 · 6 comments
Assignees
Labels
datasets Geospatial or benchmark datasets

Comments

@mizoru
Copy link

mizoru commented Nov 13, 2023

Description

The file top_potsdam_4_12_label.tif in 5_Labels_all.zip isn't actually the mask, but seemts to be the mask overlayed on the RGB image. This leads to the 8th sample in the dataset having an all-zero mask. 5_Labels_for_participants.zip does contain the proper mask. Substituting with the image from that archive seems to solve the issue.
Making it so that rgb_to_mask gives a warning about pixels not in the colormap would be good as well.

Steps to reproduce

  1. Download the dataset from the official link
  2. Check the file mentioned above (it's clear from its size that it's different).

Version

0.5.0

@adamjstewart adamjstewart added the datasets Geospatial or benchmark datasets label Nov 13, 2023
@adamjstewart
Copy link
Collaborator

@isaaccorley you added the original Potsdam data loader, can you take a look into this?

@isaaccorley
Copy link
Collaborator

I took a look at this and I think the dataset may have been updated or something because I have a prior version of Potsdam that doesn't seem to have this issue.

@isaaccorley
Copy link
Collaborator

I'll make a PR once I figure out the best way to handle this in the dataset class.

@adamjstewart
Copy link
Collaborator

We haven't yet found a license for it so we can't just rehost on HF 😢

@isaaccorley
Copy link
Collaborator

The download times for their server are awful for me. It hosts Vaihingen as well

@adamjstewart
Copy link
Collaborator

Can you try reaching out to them and find out about this bug and the license? If we know the license we can likely rehost on HF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets
Projects
None yet
Development

No branches or pull requests

3 participants