Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xView dataset to return image1, image2 #1691

Open
robmarkcole opened this issue Oct 23, 2023 · 3 comments
Open

Update xView dataset to return image1, image2 #1691

robmarkcole opened this issue Oct 23, 2023 · 3 comments
Labels
backwards-incompatible Changes that are not backwards compatible datasets Geospatial or benchmark datasets

Comments

@robmarkcole
Copy link
Contributor

robmarkcole commented Oct 23, 2023

Summary

#1684 updated OSCD to return ["image1", "image2", "mask"]. This issue is to track other CD datasets that require this change:

Rationale

Make consistent interface for change detection models

Implementation

No response

Alternatives

No response

Additional information

No response

@adamjstewart
Copy link
Collaborator

Note

Once we have a ChangeDetectionTask, we can remove the tests/datamodules/*.py files for these datasets and test them properly with a real trainer. Related to #978.

@adamjstewart adamjstewart added datasets Geospatial or benchmark datasets backwards-incompatible Changes that are not backwards compatible labels Oct 23, 2023
@adamjstewart
Copy link
Collaborator

Are there any change detection datasets with more than 2 images? Wonder if it would make sense to model this similar to a time-series dataset. @nilsleh is working on this but idk if we've finalized the design yet.

@robmarkcole
Copy link
Contributor Author

Possibly Spacenet 7 - but broadly speaking change detection is a special case of time series, so an API that extends image1, image2, 3,4 etc makes sense

@robmarkcole robmarkcole changed the title Update change detection datasets to return image1, image2 Update xView dataset to return image1, image2 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompatible Changes that are not backwards compatible datasets Geospatial or benchmark datasets
Projects
None yet
Development

No branches or pull requests

2 participants