Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu on tabs doesn't close when clicking in the title bar #7988

Closed
jroessel opened this issue Oct 21, 2020 · 5 comments · Fixed by #8010
Closed

Context menu on tabs doesn't close when clicking in the title bar #7988

jroessel opened this issue Oct 21, 2020 · 5 comments · Fixed by #8010
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone

Comments

@jroessel
Copy link

jroessel commented Oct 21, 2020

Environment

PS> [System.Environment]::OSVersion

Platform ServicePack Version      VersionString
-------- ----------- -------      -------------
 Win32NT             10.0.19041.0 Microsoft Windows NT 10.0.19041.0

Windows Terminal
Version: 1.3.2651.0

Steps to reproduce

  1. Right click on a tab in Windows Terminal to open the context menu.
  2. Click somewhere else to close it again.

Expected behavior

The context menu closes, regardless of where the click in step 2 goes.

Actual behavior

The context menu closes in pretty much all places, even different applications (presumably because losing focus also closes it), but doesn't close when clicking the title bar of WIndows Terminal. It does close when clicking controls in the title bar, though, even the default window buttons in the upper right.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 21, 2020
@zadjii-msft
Copy link
Member

Well that's the darndest thing. I bet this is the same thing as #2028 (which was fixed in #2438), but with the tab context fylout menu, not the new tab flyout.

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Oct 21, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 21, 2020
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Oct 21, 2020
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 21, 2020
@ghost ghost added the In-PR This issue has a related PR label Oct 22, 2020
@jroessel
Copy link
Author

Coming only from higher-level UI toolkits in managed code I always thought the popup was somewhat responsible for closing itself by getting mouse capture and reacting to clicks elsewhere and closing itself. But perhaps that's the more complicated or otherwise undesirable option in native Win32. No actual idea, though :)

@DHowett
Copy link
Member

DHowett commented Oct 27, 2020

Coming only from higher-level UI toolkits in managed code I always thought the popup was somewhat responsible for closing itself by getting mouse capture and reacting to clicks elsewhere and closing itself. But perhaps that's the more complicated or otherwise undesirable option in native Win32. No actual idea, though :)

You're totally right, @jroessel! We're in the unfortunate position of using two different UI frameworks at the same time (XAML and Win32). To get our titlebar draggable while still being able to theme it like the rest of the application, we had to eat mouse clicks in a region at the top of the window. Doing that obscures the click target that would dismiss the flyout menu 😄

@ghost ghost closed this as completed in #8010 Oct 27, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 27, 2020
ghost pushed a commit that referenced this issue Oct 27, 2020
Close the tab context menu when clicking on the title bar

## Detailed Description of the Pull Request / Additional comments
Following #2438, hide the tabs context menu on `TerminalPage::TitlebarClicked()`. 
We don't know which of the tabs is showing the context menu, do it on all tabs.

## Validation Steps Performed
Open the context menu from any tab, click on title bar and see the context menu disappear.

Closes #7988
DHowett pushed a commit that referenced this issue Oct 28, 2020
Close the tab context menu when clicking on the title bar

## Detailed Description of the Pull Request / Additional comments
Following #2438, hide the tabs context menu on `TerminalPage::TitlebarClicked()`.
We don't know which of the tabs is showing the context menu, do it on all tabs.

## Validation Steps Performed
Open the context menu from any tab, click on title bar and see the context menu disappear.

Closes #7988

(cherry picked from commit 7e86001)
@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #8010, which has now been successfully released as Windows Terminal v1.4.3141.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #8010, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants