Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Padding breaks mouse selection #660

Closed
ghvanderweg opened this issue May 10, 2019 · 3 comments · Fixed by #906
Closed

Padding breaks mouse selection #660

ghvanderweg opened this issue May 10, 2019 · 3 comments · Fixed by #906
Assignees
@carlos-zamora
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.0

Comments

@ghvanderweg
Copy link

ghvanderweg commented May 10, 2019 •
edited

Adding padding to a profile (e.g. "padding": "20, 20, 20, 20") breaks selecting text with your mouse. The selection is offset with the padding.

terminal

edit: Windows build 10.0.18890.1000, just in case that's relevant
@mwidmann
Copy link

I noticed this in 18362.86 as well. It's not as bad as in your case as I have set the padding to be 10, 10, 10, 10 only.

@zadjii-msft
Copy link
Member

I believe @carlos-zamora is working on this :)

@zadjii-msft zadjii-msft added this to the Windows Terminal v1.0 milestone May 10, 2019
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. labels May 10, 2019
@carlos-zamora
Copy link
Member

Yeah. It's off by the amount of padding. I have it in code review in our other system (still transitioning over to GitHub) so this'll be fixed soon. 😊

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@miniksa miniksa added Product-Terminal The new Windows Terminal. and removed Mass-Chaos labels May 17, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@carlos-zamora carlos-zamora mentioned this issue May 20, 2019
Merged
5 tasks
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 22, 2019
DHowett-MSFT pushed a commit that referenced this issue May 22, 2019
@carlos-zamora @DHowett
Bugfix: padding offsets selection (#906)
6a79025 
Closes #660.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Bugfix: padding offsets selection microsoft/terminal
5 participants
@mwidmann @carlos-zamora @ghvanderweg @miniksa @zadjii-msft