Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: align design with other UWP apps #615

Closed
warpdesign opened this issue May 9, 2019 · 3 comments · Fixed by #1934
Closed

UI: align design with other UWP apps #615

warpdesign opened this issue May 9, 2019 · 3 comments · Fixed by #1934
Assignees
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone

Comments

@warpdesign
Copy link

It seems the design isn't following other Windows/UWP apps/components. The + button to add a tab seems very big and bold (it's even bigger than close/minimize window buttons).

Here is a comparison with Edge:

image

Also, it's positionned at the right edge of the window instead of being next to the last tab like in Edge.

@warpdesign warpdesign changed the title [Suggestion] UI: align design with other UWP apps UI: align design with other UWP apps May 9, 2019
@zadjii-msft
Copy link
Member

Yea, the design of the tab row right now is under pretty active updating. There are actual UX designs/mockups that are being worked on by the design team currently, but until they're finalized, we don't want to waste time futzing with the styling if it's just going to change.

I'm also on board with the plus button being at the end of the tabs, instead of at the end of the tab row, but some people actually really like it where it is. I think this is something we're inevitably going to have a setting to control :)

@zadjii-msft zadjii-msft added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 9, 2019
@zadjii-msft zadjii-msft added this to the Windows Terminal v1.0 milestone May 9, 2019
@warpdesign
Copy link
Author

I see: it's not needed to waste time until the design is ready indeed. I also have my preferences, but above all I like consistency across every app: I hope all teams will share the same UI/Design/components :)

@miniksa miniksa added the Area-User Interface Issues pertaining to the user interface of the Console or Terminal label May 9, 2019
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@miniksa miniksa added Product-Terminal The new Windows Terminal. and removed Mass-Chaos labels May 17, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@zadjii-msft zadjii-msft added Issue-Task It's a feature request, but it doesn't really need a major design. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Jun 20, 2019
@cinnamon-msft cinnamon-msft self-assigned this Jun 25, 2019
@ghost ghost added the In-PR This issue has a related PR label Jul 11, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 12, 2019
@ghost
Copy link

ghost commented Aug 3, 2019

🎉This issue was addressed in #1934, which has now been successfully released as Windows Terminal Preview v0.3.2142.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants