Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorTool: parser bugfixes and small code refactor #413

Closed
waf opened this issue Apr 21, 2019 · 3 comments
Closed

ColorTool: parser bugfixes and small code refactor #413

waf opened this issue Apr 21, 2019 · 3 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Colortool This is a problem with the utility application ColorTool for manipulating the console color palette. Resolution-Fix-Available It's available in an Insiders build or a release

Comments

@waf
Copy link
Contributor

waf commented Apr 21, 2019

I'm using ColorTool as part of managing a theme for cmd / powershell, and I've run into a few issues using it:

  1. Error messages being thrown from parsers that are unused, e.g. the INI parser tries to run even if you are using itermcolors, so it throws errors because XML is not a valid INI file.
  2. Foreground / Background indexes aren't saved when using --defaults (or --both).

These are easy enough fixes and I'm happy to fix them. I was thinking of cleaning up the code a little bit while I'm there, namely:

  1. Allowing parsers to conditionally run, so not all parsers run for every file (should squelch some errors)
  2. Adding a common interface for "setting current console properties" and "console defaults," so it's harder to forget implementing functionality for either.

However, before I start working on this, I wanted to give you a heads-up, and make sure I wasn't working at cross-purposes with someone on the project. Would you be interested in a PR that fixes the above 2 points?

Thanks!

@DHowett-MSFT
Copy link
Contributor

@waf, that would be a very welcome change. Nobody on our side is currently working on either of those.

@waf
Copy link
Contributor Author

waf commented Apr 25, 2019

@DHowett-MSFT thanks, I've opened #418 for this.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@miniksa miniksa added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Colortool This is a problem with the utility application ColorTool for manipulating the console color palette. Resolution-Fix-Available It's available in an Insiders build or a release and removed Mass-Chaos labels May 17, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 18, 2019
@miniksa
Copy link
Member

miniksa commented May 18, 2019

I believe this is now available in the release I made a few weeks ago.

@miniksa miniksa closed this as completed May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Colortool This is a problem with the utility application ColorTool for manipulating the console color palette. Resolution-Fix-Available It's available in an Insiders build or a release
Projects
None yet
Development

No branches or pull requests

3 participants