Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Win-Key resets scroll location #2506

Closed
wolf99 opened this issue Aug 21, 2019 · 3 comments · Fixed by #2514
Closed

Win-Key resets scroll location #2506

wolf99 opened this issue Aug 21, 2019 · 3 comments · Fixed by #2514
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@wolf99
Copy link
Contributor

wolf99 commented Aug 21, 2019 •
edited

Environment

Windows build number: Microsoft Windows [Version 10.0.18362.295]
Windows Terminal version (if applicable): Version: 0.3.2171.0

Steps to reproduce

  1. Pick a shell (any shell) ✨
  2. Run any commend (or just mash the enter key) that produces enough output to push the screen down (not sure what the technical phrase for this is).
  3. Scroll back up to look at some portion of the output
  4. Push the Win-key

Expected behavior

Terminal scroll position is not affected

Actual behavior

Terminal scroll position is returned to the current prompt location/line

Particularly annoying as trackpad scrolling is also broken
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 21, 2019
@DHowett-MSFT DHowett-MSFT added Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Aug 22, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 22, 2019
@DHowett-MSFT DHowett-MSFT added Needs-Tag-Fix Doesn't match tag requirements and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 22, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 22, 2019
@marcelfreiberg marcelfreiberg mentioned this issue Aug 22, 2019
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Aug 22, 2019
DHowett-MSFT pushed a commit that referenced this issue Aug 23, 2019
@marcelfreiberg @DHowett
Don't treat the Windows keys as input (#2514)
02d8df8 
Fixes #2506.
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 23, 2019
@wolf99
Copy link
Contributor Author

wolf99 commented Aug 24, 2019

Awesome, thanks @frieb98 & @DHowett-MSFT !

@DHowett-MSFT
Copy link
Contributor

That was all @freib98's work 😄

@ghost
Copy link

ghost commented Aug 27, 2019

🎉This issue was addressed in #2514, which has now been successfully released as Windows Terminal Preview v0.4.2382.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix win key resets scroll location
2 participants
@wolf99 @DHowett-MSFT