Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reports that some processes continue running even after the tab has been closed #2232

Closed
r0mflip opened this issue Aug 4, 2019 · 3 comments
Closed

reports that some processes continue running even after the tab has been closed #2232

r0mflip opened this issue Aug 4, 2019 · 3 comments
Labels
Area-Interop Communication between processes Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.0

Comments

@r0mflip
Copy link

r0mflip commented Aug 4, 2019

Environment

Windows build number: 10.0.18362.239
Windows Terminal version: 0.3.2142.0
Any other software?
* Clink v0.4.9 [git:2fd2c2] (setup to autoinject, http://mridgers.github.io/clink)
* clink installed by using scoop

Steps to reproduce

  1. Install clink from cmd
$ clink autorun install
  1. Configure terminal default profile to cmd "defaultProfile" : "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}"
  2. Open and close Terminal (UI close button, don't use exit command)

This problem didn't exist in previous public preview build.

Expected behavior

Terminal to exit normally with clink setup.

Actual behavior

Default cmd profile in Terminal with clink setup to autorun, Terminal fails to exit properly and runs in background even after closing.

  • Terminal with clink autorun setup and running normally:
    image

  • Terminal closed normally (UI close button), still running:
    image

When the command exit is used, the terminal exits without the above problem.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 4, 2019
@lksilesian
Copy link

lksilesian commented Aug 4, 2019 •
edited

Same behavior here. Also try opening dynamic port forward - it did stuck after closing terminal and started consuming cpu cycles, but i'm unable to reproduce.

pwsh.exe hangs also

@DHowett-MSFT
Copy link
Contributor

These things should be helped by #2198.

@DHowett-MSFT DHowett-MSFT added Area-Interop Communication between processes Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Aug 5, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 5, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Aug 5, 2019
@zadjii-msft zadjii-msft mentioned this issue Aug 14, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Aug 16, 2019
Closed
@DHowett-MSFT DHowett-MSFT changed the title cmd with clink injection running in background even after closing reports that some processes continue running even after the tab has been closed Aug 16, 2019
@DHowett-MSFT DHowett-MSFT added Help Wanted We encourage anyone to jump in on these. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 16, 2019
@r0mflip
Copy link
Author

r0mflip commented Sep 1, 2019

Looks like this is fixed in tag v0.4.2382.0 🎉 by #2198. Closing for now.

@r0mflip r0mflip closed this as completed Sep 1, 2019
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Sep 1, 2019
@Lakerfield Lakerfield mentioned this issue May 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Interop Communication between processes Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.0
Development

No branches or pull requests
4 participants
@DHowett-MSFT @zadjii-msft @r0mflip @lksilesian