Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report - Tab shows icon #1862

Closed
TayYuanGeng opened this issue Jul 8, 2019 · 3 comments
Closed

Bug Report - Tab shows icon #1862

TayYuanGeng opened this issue Jul 8, 2019 · 3 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Milestone

Comments

@TayYuanGeng
Copy link

TayYuanGeng commented Jul 8, 2019

Environment

Microsoft Windows [Version 10.0.18362.207]
Windows Terminal version (if applicable): 0.2.1715.0

Steps to reproduce

Start Windows Terminal,
Spam open different types of terminal (using hotkeys),
Preferably spamming Ubuntu, cmd and PowerShell,
Some tabs collapsed into showing just icon while others are expanded.

Expected behavior

  1. The tabs should be standardised and collapsed only when there are too many tabs to fit in.
  2. The tabs will only expand when there are enough space to fit in.

Actual behavior

Screenshot belows show what it looks like:
Some of the tabs are expanded while others are not.
image
Cleared remaining tabs and only left with collapsed tab, it does not expand every tab but the last tab.
image

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 8, 2019
@zadjii-msft
Copy link
Member

@TayYuanGeng So we're definitely not doing any auto-collapsing of the tabs to icons. What's probably happening here is the shell isn't starting up entirely, and it's not setting the title.

After playing with this I can get this to repro myself. Focusing the tab also doesn't seem to set the title anymore. However, if you have the tab that's broken focused, then unfocus the window and re-focus the window, the title will update.

We must be missing some title change event, but for whatever reason we think that we did actually set the title. Either that, or there might be some bug in the tab control itself, since the window focus thing seems insane to me.

@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Jul 8, 2019
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Jul 8, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 8, 2019
@TayYuanGeng
Copy link
Author

Apparently, I tried to focus and unfocus. It DOES update BUT for ONLY the last tab. In between the expanded tabs are those collapsed tab.

@DHowett-MSFT
Copy link
Contributor

This'll be fixed by #1205. Thanks for the report!

@DHowett-MSFT DHowett-MSFT added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants