Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mouse panning (middle-button scrolling) #1701

Open
mcpiroman opened this issue Jun 28, 2019 · 4 comments
Open

Mouse panning (middle-button scrolling) #1701

mcpiroman opened this issue Jun 28, 2019 · 4 comments
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@mcpiroman
Copy link
Contributor

Summary of the new feature/enhancement

Introduce scrolling with middle mouse button, common to browsers/text editors and also available in conhost.

Currently middle mouse button is not used (right?) but there are requests to use it to paste text, so there needs to be a settings for that.

Proposed technical implementation details (optional)

PR #1523 introduces mechanism to implement scrolling, cursor image has to be replaced with appropriate images.
@mcpiroman mcpiroman added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 28, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 28, 2019
@miniksa
Copy link
Member

miniksa commented Jun 28, 2019

Does this conflict with the proposal from #1612?

That's my major concern.

Also, I don't mind implementing panning on middle mouse if that's what we decide to do (instead of copy-paste) to make it more like conhost.

My only concern is that conhost accomplished the middle click panning through a gross, old, private API call. I don't want to accomplish it the same way. If we can do it another way, I'm good with that.

@miniksa miniksa added Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Product-Terminal The new Windows Terminal. labels Jun 28, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 28, 2019
@mcpiroman
Copy link
Contributor Author

My only concern is that conhost accomplished the middle click panning through a gross, old, private API call. I don't want to accomplish it the same way. If we can do it another way, I'm good with that.

Good to hear that, couse the function that conhost uses indeed seemed scary.

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 1, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal Backlog milestone Jul 1, 2019
@DHowett-MSFT
Copy link
Contributor

@carlos-zamora agrees this should be the middle button binding. We have consensus!

@mcpiroman
Copy link
Contributor Author

Actually this don't quite have to be the middle mouse button, mice have more of them (tho my's 'nly 3). It could be even keybinding. But that seems related to #1553.

@zadjii-msft zadjii-msft added Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) and removed Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) labels Jul 7, 2020
@zadjii-msft zadjii-msft mentioned this issue Feb 25, 2021
Closed
@zadjii-msft zadjii-msft added good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Feb 25, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@DHowett-MSFT @miniksa @zadjii-msft @mcpiroman