Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Please copy the content of highlighted text, after press Enter. #1315

Closed
zhwghl opened this issue Jun 19, 2019 · 5 comments
Closed

Feature Request: Please copy the content of highlighted text, after press Enter. #1315

zhwghl opened this issue Jun 19, 2019 · 5 comments
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@zhwghl
Copy link

zhwghl commented Jun 19, 2019

Please copy the content of highlighted text, after press Enter as the regular cmd.exe will do. When I was using cmd.exe I got used to copying something by highlight them and press enter, please bring this to the new Windows Terminal.
@zhwghl zhwghl added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 19, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 19, 2019
@zadjii-msft
Copy link
Member

Well this will certainly need a spec. I believe @carlos-zamora is working on a spec for mouse bindings currently, maybe this should be called out in it.

This one's tricky though, since it's technically a keybinding that only applies when there's a selection. Perhaps I should be doing the calling out in #1142. Perhaps we need to somehow still have a "selection mode" like conhost did, and keybindings that only apply to that mode. I don't know how we'd manage that, but that's what the spec is for.

@eraineri
Copy link

I would also like to see when you highlight the text the data is automatically copied with no need to do anything else.

@zhwghl
Copy link
Author

zhwghl commented Jun 24, 2019

I would also like to see when you highlight the text the data is automatically copied with no need to do anything else.

I don't think that's a good idea to automatically copy any highlighted content. This might confuse the uses.

@zhwghl
Copy link
Author

zhwghl commented Jun 24, 2019

Well this will certainly need a spec. I believe @carlos-zamora is working on a spec for mouse bindings currently, maybe this should be called out in it.
This one's tricky though, since it's technically a keybinding that only applies when there's a selection. Perhaps I should be doing the calling out in #1142. Perhaps we need to somehow still have a "selection mode" like conhost did, and keybindings that only apply to that mode. I don't know how we'd manage that, but that's what the spec is for.

If I didn't get it wrong, I believe we have mouse binding for copying by right clicking the mouse, which is now the only way to copy and pasted the highlighted content. I did not know that we don't have the selection mode and the keybinding and mousebinding are handled separately.

@DHowett-MSFT
Copy link
Contributor

We're moving all copy selection issues to #524

@DHowett-MSFT DHowett-MSFT added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 24, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eraineri @DHowett-MSFT @zhwghl @zadjii-msft