Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review algorithm samples and see if anything suspicious with global phase shows up. #1388

Open
Tracked by #1317
swernli opened this issue Apr 15, 2024 · 1 comment
Open
Tracked by #1317
Labels
enhancement New feature or request good first issue Good for newcomers samples

Comments

@swernli
Copy link
Collaborator

swernli commented Apr 15, 2024

See #1317 for more context.

Some of our samples might use patterns that interact poorly with global phase in a way that can confuse readers of the state dumps. We should review the samples and see if any changes like the qubit scoping for #1370 can mitigate that confusion. In general, samples should avoid nuanced global phase if possible.

This review may result in sub-issues for relevant sample updates or just be closed once samples have been sufficiently reviewed.

@swernli swernli changed the title Review other samples and see if anything suspicious phase-wise shows up. Review algorithm samples and see if anything suspicious with global phase shows up. Apr 15, 2024
@swernli swernli added enhancement New feature or request good first issue Good for newcomers labels Apr 15, 2024
@tcNickolas
Copy link
Member

I skimmed through our algorithms samples, the next most confusing one is Teleportation: it says teleporting one-qubit state but DumpMachine has two qubits. We should be able to use DumpRegister instead to have one-qubit states.

github-merge-queue bot pushed a commit that referenced this issue May 1, 2024
Switched dumpMachine to dumpRegister to have one-qubit states #1388
@cesarzc

---------

Co-authored-by: Joshua Aragon <jaragon32@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers samples
Projects
None yet
Development

No branches or pull requests

2 participants