Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix proxy types and don't allow None #1271

Closed
wants to merge 1 commit into from
Closed

Conversation

mxschmitt
Copy link
Member

total=False implies that a property is either allowed to be defined or not. Having additionally Optional[...] on some was not correct documentation wise since we don't filter nested dict None values out.

Fixes #1269

@mxschmitt mxschmitt closed this Apr 27, 2022
@KotlinIsland
Copy link

Why was this closed?

@mxschmitt mxschmitt deleted the fix-proxy-types branch November 2, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong ProxySettings type hints
3 participants