Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature flag needed for the org write feature #391

Open
jeffwilcox opened this issue Oct 7, 2022 · 1 comment
Open

Feature flag needed for the org write feature #391

jeffwilcox opened this issue Oct 7, 2022 · 1 comment
Labels
keep-me

Comments

@jeffwilcox
Copy link
Collaborator

We've stopped using the org accept invite endpoint of a user's token after hitting a lot of interesting edge cases.

In our latest source, we have a constant shouldAttemptAcceptingInvitations = false value in the code that should probably become a feature flag, or, a call whether to keep it or not.

What's nice when it works:

  • Single click join
  • Things just work for the user

What's not nice:

  • Issues with SAML SSO at times
  • Blocked invites issue from GitHub API at times
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added the Stale label Nov 6, 2022
@jeffwilcox jeffwilcox added keep-me and removed Stale labels Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
keep-me
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeffwilcox