Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Please allow "NextMajor" to be filtered by -before (and -after) #3255

Open
rdebath opened this issue Nov 30, 2023 · 0 comments
Assignees

Comments

@rdebath
Copy link

rdebath commented Nov 30, 2023

Describe the issue
The -before option is ignored and we get the most recent version, not Sunday's.

Scripts used to create container and cause the issue

$LastWeekEnd = [DateTime]::Today.AddDays(-[datetime]::Today.DayOfWeek)
$artifactUrl = (Get-BCArtifactUrl  -before ($LastWeekEnd.ToUniversalTime())) -select NextMajor -country $bcCountry -accept_insiderEula

Full output of scripts

PS C:\Temp> $lastWeekend = [DateTime]::Today.AddDays(-[datetime]::Today.DayOfWeek)
PS C:\Temp> $lastWeekend.ToUniversalTime()

26 November 2023 00:00:00


PS C:\Temp> Get-BCArtifactUrl -select Latest -country gb -accept_insiderEula -before ($lastWeekend.ToUniversalTime()) -storageAccount bcinsider
BcContainerHelper version 6.0.1
Setting bcartifactsCacheFolder = D:\bcartifacts.cache
BC.HelperFunctions emits usage statistics telemetry to Microsoft
https://bcinsider.azureedge.net/sandbox/24.0.14178.0/gb
PS C:\Temp> Get-BCArtifactUrl -select NextMajor -country gb -accept_insiderEula -before ($lastWeekend.ToUniversalTime())
https://bcinsider.azureedge.net/sandbox/24.0.14300.0/gb
PS C:\Temp> Get-BCArtifactUrl -select NextMajor -country gb -accept_insiderEula
https://bcinsider.azureedge.net/sandbox/24.0.14300.0/gb
PS C:\Temp>
...

Additional context

  • does it happen all the time? --> Yes
  • did it use to work? --> No, new request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants