Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab strip scroll bumpers don't disable when scrolling to the edge #2143

Closed
AmineI opened this issue Mar 20, 2020 · 3 comments · Fixed by #2162
Closed

Tab strip scroll bumpers don't disable when scrolling to the edge #2143

AmineI opened this issue Mar 20, 2020 · 3 comments · Fixed by #2162
Labels
area-TabView help wanted Issue ideal for external contributors team-Controls Issue for the Controls team

Comments

@AmineI
Copy link

AmineI commented Mar 20, 2020

Tab strip scroll bumpers don't disable when scrolling to the edge

Steps to reproduce the bug

Steps to reproduce the behavior:

  1. Add enough tabs to make the tab strip scrollable, so that the scroll arrows appear.
  2. Scroll as much as possible in one direction (left or right)

Expected behavior

The corresponding arrow should be disabled and grayed out to indicate the state of being at the complete left/right. Example with Microsoft Edge (Legacy) tab strip :

image
Screenshot above on MS Edge, after doing the repro steps, with the mouse cursor on the arrow button
As you can see, MS Edge reacts to the edges of the tab strip. (..Mandatory pun)

Actual behavior

Notice that even though you can't scroll anymore, the scroll arrow doesn't reflect this state. (Not grayed out, and reacts to clicks, even though nothing happens

image

Screenshot above on Windows Terminal, after doing the repro steps, with the mouse cursor on the arrow button

Version Info
WinUI 2.4 & WinUI 3alpha, both through their respective branches of Xaml-Controls-Gallery
So that's
NuGet package version:
Microsoft.UI.Xaml 3.0.0-alpha.200210.0
Microsoft.UI.Xaml 2.4.0-prerelease.200203002

Windows 10 version Saw the problem?
Insider Build (19577) Yes
November 2019 Update (18363)
May 2019 Update (18362)
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes/No
Mobile
Xbox
Surface Hub
IoT

Additional context

Initially noticed on Windows Terminal and filled it there microsoft/terminal#5053

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Mar 20, 2020
@marcelwgn
Copy link
Contributor

This is definitely an issue. Not only is this confusing UI wise, but this might also be an issue accessibility wise as we have buttons in the UIA tree, that don't serve a purpose in that scenario.

@ranjeshj ranjeshj added area-TabView team-Controls Issue for the Controls team help wanted Issue ideal for external contributors and removed needs-triage Issue needs to be triaged by the area owners labels Mar 23, 2020
@marcelwgn
Copy link
Contributor

If it's fine and nobody else is working on this, I would like to tackle this issue, @ranjeshj

@0x7c13
Copy link
Member

0x7c13 commented Mar 25, 2020

I created a PR here to fix the problem: #2162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-TabView help wanted Issue ideal for external contributors team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants