Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we throw a better exception instead of logging, eating and returning a null object in GCToolkit main class #256

Open
karianna opened this issue Jan 17, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@karianna
Copy link
Member

          Should we throw a better exception instead of logging, eating and returning a null object?

Originally posted by @karianna in #252 (comment)

@dsgrieve
Copy link
Member

There should be API for consuming errors from the parser and from the aggregators/aggregations. As a user of the toolkit, I should be able to receive some notification of an error or exception. There is (or will be soon) API for the event and parsing message bus. There should (or could) be an error message bus. By default, the consumer could just log. Or I could implement a consumer that take some action when an error is posted.

@karianna karianna added the enhancement New feature or request label Jan 23, 2023
@ghost ghost added this to the 3.0.1 milestone Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants