Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unexpected Expansion of FluentNavMenu on Mobile When Accessing FluentNavGroup Submenus #2022

Closed
martingagne opened this issue May 8, 2024 · 7 comments
Labels
closed:not-actionable There is no action to be taken in response to this issue.

Comments

@martingagne
Copy link

🐛 Bug Report

💻 Repro or Code Sample

https://github.com/martingagne/fluentblazor-navmenu

  • Access the application.
  • Collapse the FluentNavMenu by clicking on the menu toggle.
  • Tap on the "Settings Group" within the FluentNavMenu.
  • Observe that the entire menu expands rather than just showing the submenu links under "Settings Group".

🤔 Expected Behavior

When the FluentNavMenu is in a collapsed state, tapping on a FluentNavGroup title (e.g., "Settings Group") should only display the submenu items associated with that group without expanding the entire menu. This behavior should allow users to navigate through grouped links (submenus) while maintaining a clean, collapsed main menu interface.

😯 Current Behavior

Currently, when the FluentNavMenu is collapsed and the "Settings Group" is tapped, the entire navigation menu expands. This behavior deviates from the expected mobile-friendly functionality where only the submenu should become visible, allowing the user to remain within the compact, collapsed view of the overall menu.

🔦 Context

Trying to get my Blazor Server app to look and work nicely on mobile.

🌍 Your Environment

  • .NET 8
  • Fluent UI Blazor library Version 4.7.2
@microsoft-github-policy-service microsoft-github-policy-service bot added the triage New issue. Needs to be looked at label May 8, 2024
@vnbaaij
Copy link
Collaborator

vnbaaij commented May 8, 2024

I can't run your code as I'm not going to be at a pc for a couple of days, but going on your description it seems like what you want is what the menu on the demo site does in mobile view. Have you seen that and is that indeed how you want it to work?

@martingagne
Copy link
Author

martingagne commented May 8, 2024 via email

@vnbaaij
Copy link
Collaborator

vnbaaij commented May 8, 2024

I don't understand what you mean with the 'entire menu reopening'.

This is what I see on my Android device in Edge: https://github.com/microsoft/fluentui-blazor/assets/1761079/7df64e40-0f62-48cb-a634-a80fbaca8379

@vnbaaij vnbaaij added needs: author feedback The author of this issue needs to respond in order for us to continue investigating this issue. and removed triage New issue. Needs to be looked at labels May 9, 2024
@martingagne
Copy link
Author

Sorry @vnbaaij. I clearly did not explain this correctly. Here's a video.

Recording.2024-05-10.102953.mp4

You will see that when I click on "Settings", the left nav fully expand. Is this the expected behavior?

@vnbaaij
Copy link
Collaborator

vnbaaij commented May 10, 2024

Yes, that is the expected behavior.

When the menu itself is collapsed, you only see the 1st level items (and only if they have an icon) there is be no way to distinguish between 1st and 2nd level items if we would show them in this collapsed state as well when you expand an item with children.
The only indication to see it is an item with subitemss is the arrow on the right of the 'parent' item

@c0g1t8
Copy link
Contributor

c0g1t8 commented May 12, 2024

Please don't change this behavior. I have a large number of menu items in my application. Some of the sub menus are very similar so the context is very important.

@vnbaaij
Copy link
Collaborator

vnbaaij commented May 12, 2024

I have no intention of changing that behavior.

Closing this as it is not an issue but intended behavior.

@vnbaaij vnbaaij removed the needs: author feedback The author of this issue needs to respond in order for us to continue investigating this issue. label May 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the triage New issue. Needs to be looked at label May 12, 2024
@vnbaaij vnbaaij added closed:not-actionable There is no action to be taken in response to this issue. and removed triage New issue. Needs to be looked at labels May 12, 2024
@vnbaaij vnbaaij closed this as not planned Won't fix, can't repro, duplicate, stale May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:not-actionable There is no action to be taken in response to this issue.
Projects
None yet
Development

No branches or pull requests

3 participants