Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Autocomplete attribute in Register.razor of .Net 8 FluentUI Blazor template are incorrect resulting in autocompletion of wrong information #2017

Closed
jhogan05 opened this issue May 7, 2024 · 2 comments 路 Fixed by #2064
Assignees
Labels
area:blazor A blazor-specific issue status:needs-investigation Needs additional investigation

Comments

@jhogan05
Copy link

jhogan05 commented May 7, 2024

馃悰 Bug Report

A number of the Autocomplete attributes in Register.razor of the FluentUI Blazor template (with Individual Logins) are incorrect resulting in auto-completion of the incorrect Personal info

馃捇 Repro or Code Sample

In Visual Studio select the new "Fluent Blazor Web App" template via Create New Project, and on the second Wizard pane choose Authentication type: "Individual Accounts". Allow the Project be created, then run the Project and click on Register. Click into the email field and see the Auto-completion options offered by your browser.

馃 Expected Behavior

Should auto-suggest one existing Email address stored by the users Browser

馃槸 Current Behavior

In Edge and Chrome it is auto-suggesting the users fullname (Firstname Lastname) not the email

馃拋 Possible Solution

On Line 31 of Register.razor (in the created Web App) the markup reads incorrectly "username"

<FluentTextField Name="Input.Email" @bind-Value="Input.Email" AutoComplete="username" Required="true" Placeholder="name@example.com" Label="Email" Style="width: 100%" />

it should read "email":

<FluentTextField Name="Input.Email" @bind-Value="Input.Email" AutoComplete="email" Required="true" Placeholder="name@example.com" Label="Email" Style="width: 100%" />

Similary on Line 33:

<FluentTextField type="password" Name="Input.Password" @bind-Value="Input.Password" AutoComplete="current-password" Required="true" Placeholder="password" Label="Password" Style="width: 100%" />

AutoComplete by the guidelines should be "new-password" etc.

馃敠 Context

List of defined autcomplete attributes:

https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete#values

馃實 Your Environment

  • OS & Device: Windows 10
  • Browser Microsoft Edge, Google Chrome
  • .NET 8.0 and Fluent UI Blazor library Version 4.7.=2
@microsoft-github-policy-service microsoft-github-policy-service bot added the triage New issue. Needs to be looked at label May 7, 2024
@dvoituron
Copy link
Collaborator

Thank you, we will update this in a future release.

But the Template offers modifiable code and, as an example, I don't think it's urgent to update it. You could always create a PR to propose this change, which would help us improve the product. :-)

@vnbaaij
Copy link
Collaborator

vnbaaij commented May 9, 2024

As @dvoituron said, we will check this on our side. I copied the templates from the ASP.NET Core repo. Just checked and the user username too. Are you seeing the same with the standard templates?

@vnbaaij vnbaaij added area:blazor A blazor-specific issue status:needs-investigation Needs additional investigation and removed triage New issue. Needs to be looked at labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:blazor A blazor-specific issue status:needs-investigation Needs additional investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants