Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make Autocomplete set its height automatically #1302

Closed
aco-mreble opened this issue Jan 11, 2024 · 5 comments
Closed

feat: make Autocomplete set its height automatically #1302

aco-mreble opened this issue Jan 11, 2024 · 5 comments
Assignees
Labels
feature A new feature

Comments

@aco-mreble
Copy link
Contributor

馃檵 Feature Request

I would like to see the Autocomplete component set its height dependend on the selected items automatically.

馃 Expected Behavior

Like in outlook.com:
image

馃槸 Current Behavior

The items are only shown horizontally and overflow if too many items where selected
image

馃拋 Possible Solution

Use a text-area instead and do the rest with flexbox magic

@vnbaaij vnbaaij added feature A new feature status:needs-investigation Needs additional investigation labels Jan 11, 2024
@vnbaaij vnbaaij added this to the V4.4.0 milestone Jan 11, 2024
@dvoituron
Copy link
Collaborator

It could be interesting. Let's see what can be done

In the meantime, you can add a style overflow: auto; to display a scrollbar. It's not the same result, but it may help you out.

image

By the way, I see that there's a bug in the component that should display left/right arrows at the extremes of the Textfield, when there are more elements than space.

@dvoituron dvoituron self-assigned this Jan 12, 2024
@ra-one
Copy link

ra-one commented Jan 14, 2024

I think setting height automatically would not be the desired in all cases, may be a flag to indicate if auto-height is enabled or not. Display flipper (left/right arrow) if auto-height is disabled.

@ra-one
Copy link

ra-one commented Jan 20, 2024

@dvoituron can you please link the bug you mentioned in component, for tracking purpose.
With workaround of overflow: auto; the scrollbar does appear but since i have fixed height and width autocomplete box, the selected items still overflow the box.

image

@dvoituron
Copy link
Collaborator

dvoituron commented Jan 22, 2024

I haven't created any new bugs. I've updated to milestone to 4.4.

@dvoituron dvoituron modified the milestones: V4.4.0, V4.5.0 Feb 5, 2024
@vnbaaij vnbaaij modified the milestones: V4.5.0, V4.6.0 Mar 7, 2024
@vnbaaij vnbaaij modified the milestones: v4.6.0, v4.6.1 Apr 1, 2024
@vnbaaij vnbaaij modified the milestones: v4.6.1, v4.6.2 Apr 10, 2024
@vnbaaij vnbaaij removed this from the v4.6.2 milestone Apr 22, 2024
@dvoituron dvoituron added status:in-progress Work is in progress and removed status:needs-investigation Needs additional investigation labels May 14, 2024
@dvoituron
Copy link
Collaborator

dvoituron commented May 14, 2024

See #2045

@dvoituron dvoituron removed the status:in-progress Work is in progress label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

No branches or pull requests

4 participants