Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS Avatar backgroundColor algorithm should match iOS #392

Open
2 tasks
Saadnajmi opened this issue Jan 12, 2021 · 4 comments
Open
2 tasks

macOS Avatar backgroundColor algorithm should match iOS #392

Saadnajmi opened this issue Jan 12, 2021 · 4 comments

Comments

@Saadnajmi
Copy link
Contributor

Platform

  • iOS
  • macOS

Describe the feature that you would like added

There is a hashing algorithm in Avatar to choose a background color given the primaryText/secondaryText of the avatar.
On iOS this was purposefully chosen to match the FluentUI Android implementation. Let's use the same implementation for macOS, which currently uses a slightly different hashing algorithm resulting in different colors.

What component or utility would this be added to

macOS Avatar

Have you discussed this feature with our team, and if so, who

Yes. @markavitale and @harrieshin

Additional context/screenshots

@harrieshin
Copy link
Contributor

@kubalani we can close this now?

@Saadnajmi
Copy link
Contributor Author

The algorithms still don't match, so the same Name/Email won't give the same color. That was a followup task

@Saadnajmi
Copy link
Contributor Author

This is closed now? @kubalani

@kubalani
Copy link
Contributor

The scope of previous PR was only restricted to theme changes, I have updated the initials view algorithm to address this issue specifically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants