Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issue in TwoLineTitleView #1926

Open
1 of 2 tasks
huahuahu opened this issue Nov 13, 2023 · 0 comments
Open
1 of 2 tasks

Accessibility issue in TwoLineTitleView #1926

huahuahu opened this issue Nov 13, 2023 · 0 comments

Comments

@huahuahu
Copy link

Environment Information

  • Platform:
    • iOS
    • macOS
  • Package version(s): 0.23.0 using SwiftPM
  • Xcode and OS versions: Xcode 15.0 in MacOS 13.6.2, target is iPhone simulator 17.0

Please provide a reproduction of the bug:

Just create a TwoLineTitleView in empty view controller and check accessibility of the TwoLineTitleView.

    func addTwoLineView() {
        let twolineView = TwoLineTitleView()
        twolineView.frame = CGRect(x: 30, y: 100, width: 200, height: 40)

        twolineView.setup(title: "title", subtitle: "subtitle", interactivePart: .subtitle)
        twolineView.delegate = self
        view.addSubview(twolineView)
}

Actual behavior:

The TwoLineTitleView should act as two a11y element and tap each one would trigger the twoLineTitleViewDidTapOnTitle method.
image

Expected behavior:

The TwoLineTitleView should act as a whole a11y element as in teh Photo app
image

Priorities and help requested:

Are you willing to submit a PR to fix?: No

Requested priority: Normal

Products/applications affected: Not yet

Additional thought

I am thing what's the expected behavior here. Should we treate it as a whole element or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant