Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with MSNotificationView hide if it is not in view heirarchy #1525

Open
microsoft-kshitij opened this issue Jan 30, 2023 · 2 comments
Open
Assignees

Comments

@microsoft-kshitij
Copy link

If a MSNotificationView is created and the parent view is dismissed, the MSNotificationView crashes inside the hide function. This particularly happens when we specify a delay for the view and parent view gets dismissed before MSNotificationView delay expires.

@harrieshin
Copy link
Contributor

before the parentview is dismissed, why isn't the msnotfication not deallocated/dismissed?

@microsoft-kshitij
Copy link
Author

Currently we are doing that (handling the deallocation manually). We need to do this at every instance of msnotification. However, I think this handling should be present within MSNotification, that is, it shouldn't crash independently, in case the parent view controller gets de-allocated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants