Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you need onStartupFinished? #264

Open
TylerLeonhardt opened this issue Oct 31, 2022 · 1 comment
Open

Do you need onStartupFinished? #264

TylerLeonhardt opened this issue Oct 31, 2022 · 1 comment

Comments

@TylerLeonhardt
Copy link
Member

Describe the bug

When you are onStartupFinished activated, you compete with vscode for start up time and as a result, you hurt vscode's full startup time in the process.

It's better to be reactive and only activate when the user interacts with your extension:

  • via a command
  • via a view being visible

To Reproduce
Steps to reproduce the behavior:

  1. Go to vscode.dev
  2. install codetour
  3. reload the window
  4. codetour is activated

Expected behavior
It shouldn't activate until needed.

Additional context
The line in the package.json is here:
https://github.com/microsoft/codetour/blob/main/package.json#L34

Activation events for your reference (even though I know you know where these are)
https://code.visualstudio.com/api/references/activation-events

@trcoffman
Copy link

This project seems to be abandoned, I can't even get a code review on the feature I've contributed. I wouldn't expect this to get changed unless you write the change yourself. Perhaps we should fork the project and release our fork to the vs code marketplace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants