Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

[JS VA] Not able to process OAuth request in skill #1715

Closed
yuuzora opened this issue Jul 3, 2019 · 5 comments
Closed

[JS VA] Not able to process OAuth request in skill #1715

yuuzora opened this issue Jul 3, 2019 · 5 comments
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. Status: Backlog This will go in the product backlog Status: Blocked Current progress is blocked

Comments

@yuuzora
Copy link

yuuzora commented Jul 3, 2019

#Typescript

I built a skill wich connect to an external platform and ask to sign in via OAuth2, it's working pretty well.

The problem comes when I launch this skill with the Virtual Assistant, the dispatch works correctly and the skill is able to recognize the intent etc...
Everything just stop at this line, no error, nothing :
sc.beginDialog('uniqueOauthPromptId');

After further investigation, it has come to my attention that working with a skill and working with a skill FROM the virtual assistant implies working with two differents adapter

So, the OauthPrompt seems to relies a lot on the adapter and doesn't seems to work with an SkillHttpBotAdapter adapter.

Is my way of doing the Oauth call is wrong and I should do it in the virtual assistant or is it just a bug ?

@yuuzora yuuzora added the Type: Bug Something isn't working label Jul 3, 2019
@darrenj
Copy link
Contributor

darrenj commented Jul 3, 2019

Hi Zack,

We are waiting on an updated Websockets adapter for JS Skill support which should unblock skill invocation and also ensure Auth works (currently only supported by the BotFramework Adapter). This may not be an option for you but a C# VA should work fine - you can add a typescript based skill to it and see it all working end to end (@dfavretto and team can confirm if that combination works as expected).

We are expecting the updated library any day and will get the packages/generator updated. In the meantime you can test your Skill directly using Emulator and other channels which may unblock you too?

@darrenj darrenj changed the title Not able to process OAuth request in skill [JS VA] Not able to process OAuth request in skill Jul 3, 2019
@Batta32 Batta32 self-assigned this Jul 3, 2019
@yuuzora
Copy link
Author

yuuzora commented Jul 3, 2019

I'll stick to testing my skill directly on the emulator until it's fixed then !
Thanks for the quick answer

@Batta32
Copy link
Collaborator

Batta32 commented Jul 3, 2019

Hi @Zack-Strife,

We are migrating the latest changes to the TypeScript libraries (botbuilder-skills and botbuilder-solutions). However, we are expecting the changes in the WebSocket adapter for JS to implement that functionality in the libraries.

In the meantime, you can use a Virtual Assistant in C# as @darrenj said!

@lauren-mills lauren-mills added Status: Backlog This will go in the product backlog Status: Blocked Current progress is blocked and removed Type: Bug Something isn't working labels Jul 3, 2019
@lauren-mills lauren-mills added this to Backlog in Core (Templates, Libraries, and Samples) via automation Jul 3, 2019
@xieofxie
Copy link
Contributor

xieofxie commented Jul 4, 2019

If it is authed in VA, you have to modify function GetAuthenticationProvider in library Solutions manually. It will throw Exception for OAuth 2 now.. See #1386

@darrenj darrenj added the customer-reported Issue is created by anyone that is not a collaborator in the repository. label Jul 23, 2019
@lauren-mills lauren-mills added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. labels Aug 15, 2019
@lauren-mills lauren-mills added this to Backlog in BotSkills CLI & JS Skill Template via automation Sep 17, 2019
@lauren-mills lauren-mills removed this from Backlog (Ready for development) in Core (Templates, Libraries, and Samples) Sep 17, 2019
@darrenj
Copy link
Contributor

darrenj commented Oct 8, 2019

Work is tracked here and targeting next release. Please keep an eye on the issue and we'll point at daily builds when available.

@darrenj darrenj closed this as completed Oct 8, 2019
BotSkills CLI & JS Skill Template automation moved this from Backlog to Done Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. Status: Backlog This will go in the product backlog Status: Blocked Current progress is blocked
Development

No branches or pull requests

5 participants