Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT] logPersonalInformation flag missing in QnAMakerDialog #2779

Closed
matiasroldan6 opened this issue Sep 11, 2020 · 2 comments · Fixed by #2939
Closed

[PORT] logPersonalInformation flag missing in QnAMakerDialog #2779

matiasroldan6 opened this issue Sep 11, 2020 · 2 comments · Fixed by #2939
Assignees
@Zerryth
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository.

Comments

@matiasroldan6
Copy link
Contributor

matiasroldan6 commented Sep 11, 2020 •
edited

Describe the bug

The class QnAMakerDialog is missing the logPersonalInformation flag which is present in C#. This causes, among other things, issues with telemetry reporting in Power BI.
The flag, in turn, is not being passed by constructor to QnAMaker in the method getQnAClient, unlike the behavior in C#.

image

image

Expected behavior

The class QnAMaker should have parity with C#, and telemetry should be being reported.

Additional context
@matiasroldan6 matiasroldan6 added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Sep 11, 2020
@matiasroldan6 matiasroldan6 mentioned this issue Sep 11, 2020
Closed
@tsuwandy tsuwandy added the customer-reported Issue is created by anyone that is not a collaborator in the repository. label Sep 14, 2020
@tsuwandy
Copy link
Contributor

@stevengum , @EricDahlvang, could one of you take a look?

@tdurnford tdurnford added the Bot Services Required for internal Azure reporting. Do not delete. Do not change color. label Sep 14, 2020
@mrivera-ms mrivera-ms removed the needs-triage The issue has just been created and it has not been reviewed by the team. label Sep 18, 2020
@Zerryth
Copy link
Contributor

Zerryth commented Sep 18, 2020

@matiasroldan6 , can confirm that you are correct, we are missing logPersonalInformation in QnAMakerDialog.getQnAClient().
Looks like the JS SDK also fails to pass along options as well.

Working on a fix now.

@Zerryth Zerryth added the customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. label Sep 18, 2020
@Zerryth Zerryth mentioned this issue Oct 22, 2020
Merged
@fran893 fran893 mentioned this issue Mar 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zerryth Zerryth

Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository.
Projects
None yet
Milestone
No milestone
5 participants
@tsuwandy @tdurnford @matiasroldan6 @Zerryth @mrivera-ms