Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Adding csproj to the react-flux-babel-karma #87

Open
johnnyreilly opened this issue Mar 29, 2016 · 3 comments
Open

Adding csproj to the react-flux-babel-karma #87

johnnyreilly opened this issue Mar 29, 2016 · 3 comments

Comments

@johnnyreilly
Copy link
Contributor

Heya,

Someone asked me a while ago to add a csproj to this project so if they want to use Visual Studio as their editor they can without fiddling with setup themselves. Apparently the advice currently in place is slightly problematic. I'm up for doing the work but I thought I'd check first if you were likely to take the PR?

I'd probably use this as a basis for plugging Visual Studio into the mix:

https://github.com/johnnyreilly/poorclaresarundel/tree/master/PoorClaresAngular

I'm using this approach demonstrated in this repo commercially so I'm fairly happy it's battle tested.

But as I say, your call if you want it.

@mhegazy
Copy link
Contributor

mhegazy commented Mar 29, 2016

@johnnyreilly so what is the concern of adding the VS integration piece? is it the size? complexity? can you elaborate?

@johnnyreilly
Copy link
Contributor Author

There's some jiggery pokery to run in watch mode in vs whilst in debug mode and doing a complete build once with modification etc when in release mode. Essentially the setup turns VS into just a TypeScript editor by adding the nuget package for TypeScript and then deactivating the msbuild version of TypeScript compilation in favour of the non / Webpack one.

@johnnyreilly
Copy link
Contributor Author

As I say it's already tried and tested but you might feel it's slightly complex and so not a good fit for samples which are, in the main, quite simple.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants